| Message ID | 20241216075819.2066772-3-larisa.grigore@oss.nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add eDMAv3 support for S32G2/S32G3 SoCs | expand |
On Mon, Dec 16, 2024 at 09:58:12AM +0200, Larisa Grigore wrote: > Clean up dead code. dmamuxs is always 0 when FSL_EDMA_DRV_SPLIT_REG set. So > it is redundant to check FSL_EDMA_DRV_SPLIT_REG again in the for loop > because it will never enter for loop. > > Signed-off-by: Larisa Grigore <larisa.grigore@oss.nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > drivers/dma/fsl-edma-main.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c > index 2a7d19f51287..9873cce00c68 100644 > --- a/drivers/dma/fsl-edma-main.c > +++ b/drivers/dma/fsl-edma-main.c > @@ -517,10 +517,6 @@ static int fsl_edma_probe(struct platform_device *pdev) > for (i = 0; i < fsl_edma->drvdata->dmamuxs; i++) { > char clkname[32]; > > - /* eDMAv3 mux register move to TCD area if ch_mux exist */ > - if (drvdata->flags & FSL_EDMA_DRV_SPLIT_REG) > - break; > - > fsl_edma->muxbase[i] = devm_platform_ioremap_resource(pdev, > 1 + i); > if (IS_ERR(fsl_edma->muxbase[i])) { > -- > 2.47.0 >
diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c index 2a7d19f51287..9873cce00c68 100644 --- a/drivers/dma/fsl-edma-main.c +++ b/drivers/dma/fsl-edma-main.c @@ -517,10 +517,6 @@ static int fsl_edma_probe(struct platform_device *pdev) for (i = 0; i < fsl_edma->drvdata->dmamuxs; i++) { char clkname[32]; - /* eDMAv3 mux register move to TCD area if ch_mux exist */ - if (drvdata->flags & FSL_EDMA_DRV_SPLIT_REG) - break; - fsl_edma->muxbase[i] = devm_platform_ioremap_resource(pdev, 1 + i); if (IS_ERR(fsl_edma->muxbase[i])) {
Clean up dead code. dmamuxs is always 0 when FSL_EDMA_DRV_SPLIT_REG set. So it is redundant to check FSL_EDMA_DRV_SPLIT_REG again in the for loop because it will never enter for loop. Signed-off-by: Larisa Grigore <larisa.grigore@oss.nxp.com> --- drivers/dma/fsl-edma-main.c | 4 ---- 1 file changed, 4 deletions(-)