mbox series

[v2,0/2] Microchip CoreI2C driver fixes

Message ID 20241218-steadier-corridor-0c0a0ce58ca2@spud (mailing list archive)
Headers show
Series Microchip CoreI2C driver fixes | expand

Message

Conor Dooley Dec. 18, 2024, 12:07 p.m. UTC
From: Conor Dooley <conor.dooley@microchip.com>

Yo,

Here's a v2 with one of the minor items pointed out by Andi resolved and
a new patch for an issue fixed in the months since v1, plus some minor
checkpatch things that I seem to have missed on v1. On v1 there was
unresolved discussion with Wolfram, but it has been two months without a
response so I am sending this v2 in an attempt to make progress.

Cheers,
Conor.

v2:
- remove extra () Andi pointed out
- fix some {} use that defied the coding style
- new patch for "ghost detections"

v1: https://lore.kernel.org/linux-i2c/20240930-uneasy-dorsal-1acda9227b0d@spud/

CC: Conor Dooley <conor.dooley@microchip.com>
CC: Daire McNamara <daire.mcnamara@microchip.com>
CC: Andi Shyti <andi.shyti@kernel.org>
CC: Wolfram Sang <wsa@kernel.org>
CC: linux-riscv@lists.infradead.org
CC: linux-i2c@vger.kernel.org
CC: linux-kernel@vger.kernel.org

Conor Dooley (2):
  i2c: microchip-core: actually use repeated sends
  i2c: microchip-core: fix "ghost" detections

 drivers/i2c/busses/i2c-microchip-corei2c.c | 126 ++++++++++++++++-----
 1 file changed, 96 insertions(+), 30 deletions(-)

Comments

Andi Shyti Dec. 19, 2024, 11:50 a.m. UTC | #1
Hi Conor,

On Wed, Dec 18, 2024 at 12:07:39PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Yo,
> 
> Here's a v2 with one of the minor items pointed out by Andi resolved and
> a new patch for an issue fixed in the months since v1, plus some minor
> checkpatch things that I seem to have missed on v1. On v1 there was
> unresolved discussion with Wolfram, but it has been two months without a
> response so I am sending this v2 in an attempt to make progress.
> 
> Cheers,
> Conor.
> 
> v2:
> - remove extra () Andi pointed out
> - fix some {} use that defied the coding style
> - new patch for "ghost detections"
> 
> v1: https://lore.kernel.org/linux-i2c/20240930-uneasy-dorsal-1acda9227b0d@spud/
> 
> CC: Conor Dooley <conor.dooley@microchip.com>
> CC: Daire McNamara <daire.mcnamara@microchip.com>
> CC: Andi Shyti <andi.shyti@kernel.org>
> CC: Wolfram Sang <wsa@kernel.org>
> CC: linux-riscv@lists.infradead.org
> CC: linux-i2c@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> 
> Conor Dooley (2):
>   i2c: microchip-core: actually use repeated sends
>   i2c: microchip-core: fix "ghost" detections

Thanks for your patches, they look fine to me. For self reference
I'm going to add

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

to both of them. If you don't mind, I'm going to queue them up
for next week, as I'm not accepting anymore Fixes for this week
(unless they are trivial).

Thank you,
Andi