| Message ID | 20250127173550.1222427-3-matthew.gerlach@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add PCIe Root Port support for Agilex family of chips | expand |
On 27/01/2025 18:35, Matthew Gerlach wrote: > Add a label to the soc@0 device tree node. > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> > --- > v3: > - Remove accepted patches from patch set. > --- > arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi > index 1235ba5a9865..144fe74e929e 100644 > --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi > @@ -152,7 +152,7 @@ usbphy0: usbphy { > compatible = "usb-nop-xceiv"; > }; > > - soc@0 { > + soc0: soc@0 { This shouldn't be a separate commit, really. It serves no purpose to just add the label. Just like you do not add just a define in a driver without its user. Label like this itself is pointless. It's useful for something, so this should be squashed. Best regards, Krzysztof
On Wed, 29 Jan 2025, Krzysztof Kozlowski wrote: > On 27/01/2025 18:35, Matthew Gerlach wrote: >> Add a label to the soc@0 device tree node. >> >> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> >> --- >> v3: >> - Remove accepted patches from patch set. >> --- >> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi >> index 1235ba5a9865..144fe74e929e 100644 >> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi >> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi >> @@ -152,7 +152,7 @@ usbphy0: usbphy { >> compatible = "usb-nop-xceiv"; >> }; >> >> - soc@0 { >> + soc0: soc@0 { > This shouldn't be a separate commit, really. It serves no purpose to > just add the label. Just like you do not add just a define in a driver > without its user. Label like this itself is pointless. It's useful for > something, so this should be squashed. I will squash this label change with the user of the lable. Thanks for the review, Matthew Gerlach > > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi index 1235ba5a9865..144fe74e929e 100644 --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi @@ -152,7 +152,7 @@ usbphy0: usbphy { compatible = "usb-nop-xceiv"; }; - soc@0 { + soc0: soc@0 { #address-cells = <1>; #size-cells = <1>; compatible = "simple-bus";
Add a label to the soc@0 device tree node. Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com> --- v3: - Remove accepted patches from patch set. --- arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)