| Message ID | 20250219203240.141272-1-eahariha@linux.microsoft.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | wifi: cfg80211: convert timeouts to secs_to_jiffies() | expand |
| Context | Check | Description |
|---|---|---|
| jmberg/tree_selection | success | Series ignored based on subject |
On 2/19/2025 12:32 PM, Easwar Hariharan wrote: > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the value here is a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. > > This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with > the following Coccinelle rules: > > @depends on patch@ > expression E; > @@ > > -msecs_to_jiffies(E * 1000) > +secs_to_jiffies(E) > > -msecs_to_jiffies(E * MSEC_PER_SEC) > +secs_to_jiffies(E) > > Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > --- > net/wireless/scan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/wireless/scan.c b/net/wireless/scan.c > index cd2124329521..1de25e9763cb 100644 > --- a/net/wireless/scan.c > +++ b/net/wireless/scan.c > @@ -1365,7 +1365,7 @@ void cfg80211_bss_age(struct cfg80211_registered_device *rdev, > unsigned long age_secs) > { > struct cfg80211_internal_bss *bss; > - unsigned long age_jiffies = msecs_to_jiffies(age_secs * MSEC_PER_SEC); > + unsigned long age_jiffies = secs_to_jiffies(age_secs); > > spin_lock_bh(&rdev->bss_lock); > list_for_each_entry(bss, &rdev->bss_list, list) Reviewed-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
diff --git a/net/wireless/scan.c b/net/wireless/scan.c index cd2124329521..1de25e9763cb 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -1365,7 +1365,7 @@ void cfg80211_bss_age(struct cfg80211_registered_device *rdev, unsigned long age_secs) { struct cfg80211_internal_bss *bss; - unsigned long age_jiffies = msecs_to_jiffies(age_secs * MSEC_PER_SEC); + unsigned long age_jiffies = secs_to_jiffies(age_secs); spin_lock_bh(&rdev->bss_lock); list_for_each_entry(bss, &rdev->bss_list, list)
Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced secs_to_jiffies(). As the value here is a multiple of 1000, use secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with the following Coccinelle rules: @depends on patch@ expression E; @@ -msecs_to_jiffies(E * 1000) +secs_to_jiffies(E) -msecs_to_jiffies(E * MSEC_PER_SEC) +secs_to_jiffies(E) Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> --- net/wireless/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)