| Message ID | 36dcb6fc-f292-4dd5-bd45-a8c6f9dc3df7@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: dwc: ep: Return -ENOMEM for allocation failures | expand |
Hello, > If the bitmap allocations fail then dw_pcie_ep_init_registers() currently > returns success. Return -ENOMEM instead. [...] > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > @@ -908,6 +908,7 @@ int dw_pcie_ep_init_registers(struct dw_pcie_ep *ep) > if (ret) > return ret; > > + ret = -ENOMEM; > if (!ep->ib_window_map) { > ep->ib_window_map = devm_bitmap_zalloc(dev, pci->num_ib_windows, > GFP_KERNEL); Nice catch! This will cover subsequent calls to devm_bitmap_zalloc() and devm_kcalloc(). Reviewed-by: Krzysztof Wilczyński <kw@linux.com> Thank you! Krzysztof
Hello, > If the bitmap allocations fail then dw_pcie_ep_init_registers() currently > returns success. Return -ENOMEM instead. Applied to controller/dwc, thank you! Krzysztof
diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index 20f2436c7091..1b873d486b2d 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -908,6 +908,7 @@ int dw_pcie_ep_init_registers(struct dw_pcie_ep *ep) if (ret) return ret; + ret = -ENOMEM; if (!ep->ib_window_map) { ep->ib_window_map = devm_bitmap_zalloc(dev, pci->num_ib_windows, GFP_KERNEL);
If the bitmap allocations fail then dw_pcie_ep_init_registers() currently returns success. Return -ENOMEM instead. Fixes: 869bc5253406 ("PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/pci/controller/dwc/pcie-designware-ep.c | 1 + 1 file changed, 1 insertion(+)