| Message ID | 20250326200115.3804380-2-cassel@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: rockchip-ep: Mark RK3399 as intx_capable | expand |
Hello, > RK3399 can raise INTx interrupts, as can be seen by > rockchip_pcie_ep_send_intx_irq(). > > This is also in line with the register description of > PCIE_CLIENT_LEGACY_INT_CTRL, section "17.6.3 PCIe Client Detail Register > Description" of the RK3399 TRM. > > Thus, mark RK3399 as intx_capable. Replaced the following commit: e55c67837a8c ("PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts") With this one directly on the "endpoint-test" branch. This is per the conversation at: https://lore.kernel.org/linux-pci/20250318103330.1840678-6-cassel@kernel.org Thank you! Krzysztof
Hello, > > RK3399 can raise INTx interrupts, as can be seen by > > rockchip_pcie_ep_send_intx_irq(). > > > > This is also in line with the register description of > > PCIE_CLIENT_LEGACY_INT_CTRL, section "17.6.3 PCIe Client Detail Register > > Description" of the RK3399 TRM. > > > > Thus, mark RK3399 as intx_capable. > > Replaced the following commit: > > e55c67837a8c ("PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts") > > With this one directly on the "endpoint-test" branch. This is per the > conversation at: > > https://lore.kernel.org/linux-pci/20250318103330.1840678-6-cassel@kernel.org > > Thank you! That said, Bjorn is preparing this Pull Request, this might not make the cut at this time. Krzysztof
diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c index 85ea36df2f59a..626f6b31b0f66 100644 --- a/drivers/pci/controller/pcie-rockchip-ep.c +++ b/drivers/pci/controller/pcie-rockchip-ep.c @@ -694,6 +694,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features = { .linkup_notifier = true, .msi_capable = true, .msix_capable = false, + .intx_capable = true, .align = ROCKCHIP_PCIE_AT_SIZE_ALIGN, };
RK3399 can raise INTx interrupts, as can be seen by rockchip_pcie_ep_send_intx_irq(). This is also in line with the register description of PCIE_CLIENT_LEGACY_INT_CTRL, section "17.6.3 PCIe Client Detail Register Description" of the RK3399 TRM. Thus, mark RK3399 as intx_capable. Signed-off-by: Niklas Cassel <cassel@kernel.org> --- drivers/pci/controller/pcie-rockchip-ep.c | 1 + 1 file changed, 1 insertion(+)