| Message ID | 20250324075910.407999-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Ping-Ke Shih |
| Headers | show |
| Series | wifi: rtw88: sdio: Remove redundant 'flush_workqueue()' calls | expand |
Chen Ni <nichen@iscas.ac.cn> wrote: > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; > @@ > > - flush_workqueue(E); > destroy_workqueue(E); > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> 1 patch(es) applied to rtw-next branch of rtw.git, thanks. 5c4cf36c538b wifi: rtw88: sdio: Remove redundant 'flush_workqueue()' calls --- https://github.com/pkshih/rtw.git
diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c index 6209a49312f1..682fdd84a09b 100644 --- a/drivers/net/wireless/realtek/rtw88/sdio.c +++ b/drivers/net/wireless/realtek/rtw88/sdio.c @@ -1298,7 +1298,6 @@ static void rtw_sdio_deinit_tx(struct rtw_dev *rtwdev) struct rtw_sdio *rtwsdio = (struct rtw_sdio *)rtwdev->priv; int i; - flush_workqueue(rtwsdio->txwq); destroy_workqueue(rtwsdio->txwq); kfree(rtwsdio->tx_handler_data);
'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/net/wireless/realtek/rtw88/sdio.c | 1 - 1 file changed, 1 deletion(-)