diff mbox series

[ath-next,v2] wifi: ath12k: Disable broadcast TWT feature in HE MAC capabilities

Message ID 20250409053830.4039467-1-aaradhana.sahu@oss.qualcomm.com (mailing list archive)
State Accepted
Delegated to: Jeff Johnson
Headers show
Series [ath-next,v2] wifi: ath12k: Disable broadcast TWT feature in HE MAC capabilities | expand

Checks

Context Check Description
wifibot/fixes_present success Fixes tag not required for -next series
wifibot/series_format success Single patches do not need cover letters
wifibot/tree_selection success Clearly marked for ath-next
wifibot/ynl success Generated files up to date; no warnings/errors; no diff in generated;
wifibot/build_clang success Errors and warnings before: 0 this patch: 0
wifibot/build_32bit success Errors and warnings before: 0 this patch: 0
wifibot/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
wifibot/build_clang_rust success No Rust files in patch. Skipping build
wifibot/build_tools success No tools touched, skip
wifibot/check_selftest success No net selftest shell script
wifibot/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
wifibot/deprecated_api success None detected
wifibot/header_inline success No static functions without inline keyword in header files
wifibot/kdoc success Errors and warnings before: 0 this patch: 0
wifibot/source_inline success Was 0 now: 0
wifibot/verify_fixes success No Fixes tag
wifibot/verify_signedoff success Signed-off-by tag matches author and committer

Commit Message

Aaradhana Sahu April 9, 2025, 5:38 a.m. UTC 
From: Thomas Wu <quic_wthomas@quicinc.com>

Currently, the AP does not support the broadcast target wake time (TWT)
feature. Therefore, disable the broadcast TWT feature in the HE MAC
capabilities element field.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00209-QCAHKSWPL_SILICONZ-1

Signed-off-by: Thomas Wu <quic_wthomas@quicinc.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
v2:
  -Line wrapped within 80 characters.
---
 drivers/net/wireless/ath/ath12k/mac.c | 2 ++
 1 file changed, 2 insertions(+)


base-commit: ac17b1211841c98a9b4c2900ba2a7f457c80cf90

Comments

Vasanthakumar Thiagarajan April 10, 2025, 3:53 a.m. UTC | #1 
On 4/9/2025 11:08 AM, Aaradhana Sahu wrote:
> From: Thomas Wu <quic_wthomas@quicinc.com>
> 
> Currently, the AP does not support the broadcast target wake time (TWT)
> feature. Therefore, disable the broadcast TWT feature in the HE MAC
> capabilities element field.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00209-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Thomas Wu <quic_wthomas@quicinc.com>
> Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>

Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Jeff Johnson April 12, 2025, 4:24 a.m. UTC | #2 
On Wed, 09 Apr 2025 11:08:30 +0530, Aaradhana Sahu wrote:
> Currently, the AP does not support the broadcast target wake time (TWT)
> feature. Therefore, disable the broadcast TWT feature in the HE MAC
> capabilities element field.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00209-QCAHKSWPL_SILICONZ-1
> 
> 
> [...]

Applied, thanks!

[1/1] wifi: ath12k: Disable broadcast TWT feature in HE MAC capabilities
      commit: cfe8af4b5626354f20794f1d54c9b9069638ccd3

Best regards,
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 2b6bdc3d2b11..26c0147924a3 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -6724,6 +6724,8 @@  static void ath12k_mac_copy_he_cap(struct ath12k_band_cap *band_cap,
 
 	switch (iftype) {
 	case NL80211_IFTYPE_AP:
+		he_cap_elem->mac_cap_info[2] &=
+			~IEEE80211_HE_MAC_CAP2_BCAST_TWT;
 		he_cap_elem->phy_cap_info[3] &=
 			~IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_TX_MASK;
 		he_cap_elem->phy_cap_info[9] |=