diff mbox

rt2x00: fix votage setting for RT3572/RT3592

Message ID 1346019997-14487-1-git-send-email-mkl@blackshift.org (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Marc Kleine-Budde Aug. 26, 2012, 10:26 p.m. UTC
According to the vendor driver v2.6.0.1, during the rf register init the SRAM
voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.

Cc: Gertjan van Wingerde <gwingerde@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>
---
Hello,

I don't have the hardware to test, just stumbled over this while hacking on the
rt3593.

regards,  Marc

 drivers/net/wireless/rt2x00/rt2800lib.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Ivo van Doorn Aug. 27, 2012, 8:19 a.m. UTC | #1
On Mon, Aug 27, 2012 at 12:26 AM, Marc Kleine-Budde <mkl@blackshift.org> wrote:
> According to the vendor driver v2.6.0.1, during the rf register init the SRAM
> voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
> patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
>
> Cc: Gertjan van Wingerde <gwingerde@gmail.com>
> Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>

Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

> ---
> Hello,
>
> I don't have the hardware to test, just stumbled over this while hacking on the
> rt3593.
>
> regards,  Marc
>
>  drivers/net/wireless/rt2x00/rt2800lib.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index cb8c2ac..b93516d 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -4089,6 +4089,7 @@ static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
>                 rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
>                 msleep(1);
>                 rt2800_register_read(rt2x00dev, LDO_CFG0, &reg);
> +               rt2x00_set_field32(&reg, LDO_CFG0_LDO_CORE_VLEVEL, 0);
>                 rt2x00_set_field32(&reg, LDO_CFG0_BGSEL, 1);
>                 rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
>         }
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marc Kleine-Budde Sept. 5, 2012, 8:33 a.m. UTC | #2
On 08/27/2012 10:19 AM, Ivo Van Doorn wrote:
> On Mon, Aug 27, 2012 at 12:26 AM, Marc Kleine-Budde <mkl@blackshift.org> wrote:
>> According to the vendor driver v2.6.0.1, during the rf register init the SRAM
>> voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
>> patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
>>
>> Cc: Gertjan van Wingerde <gwingerde@gmail.com>
>> Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>
> 
> Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

Ping. Is someone taking care of this patch?

Marc

> 
>> ---
>> Hello,
>>
>> I don't have the hardware to test, just stumbled over this while hacking on the
>> rt3593.
>>
>> regards,  Marc
>>
>>  drivers/net/wireless/rt2x00/rt2800lib.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
>> index cb8c2ac..b93516d 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -4089,6 +4089,7 @@ static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
>>                 rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
>>                 msleep(1);
>>                 rt2800_register_read(rt2x00dev, LDO_CFG0, &reg);
>> +               rt2x00_set_field32(&reg, LDO_CFG0_LDO_CORE_VLEVEL, 0);
>>                 rt2x00_set_field32(&reg, LDO_CFG0_BGSEL, 1);
>>                 rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
>>         }
>> --
>> 1.7.10
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gertjan van Wingerde Sept. 5, 2012, 8:19 p.m. UTC | #3
Marc,

Sent from my iPad

On 5 sep. 2012, at 10:33, Marc Kleine-Budde <mkl@blackshift.org> wrote:

> On 08/27/2012 10:19 AM, Ivo Van Doorn wrote:
>> On Mon, Aug 27, 2012 at 12:26 AM, Marc Kleine-Budde <mkl@blackshift.org> wrote:
>>> According to the vendor driver v2.6.0.1, during the rf register init the SRAM
>>> voltage should be increased to 1.35V and after 1ms decreased back to 1.2V. This
>>> patch adds the field setting of LDO_CFG0_LDO_CORE_VLEVEL accordingly.
>>> 
>>> Cc: Gertjan van Wingerde <gwingerde@gmail.com>
>>> Signed-off-by: Marc Kleine-Budde <mkl@blackshift.org>
>> 
>> Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> 
> Ping. Is someone taking care of this patch?
> 

Normally, John takes these patches after Ivo, Helmut or I have acked them.
However, I believe he was travelling last week, so it takes a bit longer to be applied.

---
Gertjan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index cb8c2ac..b93516d 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -4089,6 +4089,7 @@  static int rt2800_init_rfcsr(struct rt2x00_dev *rt2x00dev)
 		rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
 		msleep(1);
 		rt2800_register_read(rt2x00dev, LDO_CFG0, &reg);
+		rt2x00_set_field32(&reg, LDO_CFG0_LDO_CORE_VLEVEL, 0);
 		rt2x00_set_field32(&reg, LDO_CFG0_BGSEL, 1);
 		rt2800_register_write(rt2x00dev, LDO_CFG0, reg);
 	}