| Message ID | 1346251689-37023-1-git-send-email-tim.gardner@canonical.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote: > Cc: Luciano Coelho <coelho@ti.com> > Cc: "John W. Linville" <linville@tuxdriver.com> > Cc: Eliad Peller <eliad@wizery.com> > Cc: Arik Nemtsov <arik@wizery.com> > Cc: Eyal Shapira <eyal@wizery.com> > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > --- Please add a proper commit message. And there's no need to put all these people in Cc: in the commit log. CC'ing when sending the patch is enough (even though for such small patch, the linux-wireless mailing list and myself is enough). -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/29/2012 11:01 AM, Luciano Coelho wrote: > On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote: >> Cc: Luciano Coelho <coelho@ti.com> >> Cc: "John W. Linville" <linville@tuxdriver.com> >> Cc: Eliad Peller <eliad@wizery.com> >> Cc: Arik Nemtsov <arik@wizery.com> >> Cc: Eyal Shapira <eyal@wizery.com> >> Cc: linux-wireless@vger.kernel.org >> Cc: netdev@vger.kernel.org >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> >> --- > > Please add a proper commit message. And there's no need to put all > these people in Cc: in the commit log. CC'ing when sending the patch is > enough (even though for such small patch, the linux-wireless mailing > list and myself is enough). > > -- > Luca. > What more would you like covered in the commit message that isn't obvious from the subject? The Cc list comes from scripts/get_maintainers.pl as suggested by Documentation/SubmittingPatches: "5) Select e-mail destination." rtg
On Wed, 2012-08-29 at 11:13 -0600, Tim Gardner wrote: > On 08/29/2012 11:01 AM, Luciano Coelho wrote: > > On Wed, 2012-08-29 at 08:48 -0600, Tim Gardner wrote: > >> Cc: Luciano Coelho <coelho@ti.com> > >> Cc: "John W. Linville" <linville@tuxdriver.com> > >> Cc: Eliad Peller <eliad@wizery.com> > >> Cc: Arik Nemtsov <arik@wizery.com> > >> Cc: Eyal Shapira <eyal@wizery.com> > >> Cc: linux-wireless@vger.kernel.org > >> Cc: netdev@vger.kernel.org > >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > >> --- > > > > Please add a proper commit message. And there's no need to put all > > these people in Cc: in the commit log. CC'ing when sending the patch is > > enough (even though for such small patch, the linux-wireless mailing > > list and myself is enough). > > > > -- > > Luca. > > > > What more would you like covered in the commit message that isn't > obvious from the subject? It's obvious from the subject, indeed. But commits with no descriptions are ugly. Add something, for example a small "why" would be nice. > The Cc list comes from scripts/get_maintainers.pl as suggested by > Documentation/SubmittingPatches: "5) Select e-mail destination." Yeah, that's correct, but it doesn't mean you should put them as Cc: tags in the commit log. CCing when *sending* the email only is enough. Most people won't really care for the entire lifetime of this patch. And, come on, the Cc tags take more space than the actual patch. -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c index 7254860..a55ace6 100644 --- a/drivers/net/wireless/ti/wlcore/main.c +++ b/drivers/net/wireless/ti/wlcore/main.c @@ -5663,3 +5663,4 @@ MODULE_PARM_DESC(no_recovery, "Prevent HW recovery. FW will remain stuck."); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Luciano Coelho <coelho@ti.com>"); MODULE_AUTHOR("Juuso Oikarinen <juuso.oikarinen@nokia.com>"); +MODULE_FIRMWARE(WL12XX_NVS_NAME);
Cc: Luciano Coelho <coelho@ti.com> Cc: "John W. Linville" <linville@tuxdriver.com> Cc: Eliad Peller <eliad@wizery.com> Cc: Arik Nemtsov <arik@wizery.com> Cc: Eyal Shapira <eyal@wizery.com> Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Tim Gardner <tim.gardner@canonical.com> --- drivers/net/wireless/ti/wlcore/main.c | 1 + 1 file changed, 1 insertion(+)