diff mbox

Linux 3.7-rc1 (nouveau_bios_score oops).

Message ID 50827174.7070109@labri.fr (mailing list archive)
State New, archived
Headers show

Commit Message

Martin Peres Oct. 20, 2012, 9:40 a.m. UTC
On 20/10/2012 11:26, Heinz Diehl wrote:
> On 20.10.2012, Linus Torvalds wrote:
>
>> Added more appropriate people to this. Added both i915 and nouveau
>> people, since apparently that fine piece of hardware has both.
>>
>> Guys, any ideas?
>
> Plese see https://lkml.org/lkml/2012/10/19/371 , this is the same
> thing going on. Reverting
>
>   Ben Skeggs <bskeggs@redhat.com>
>   drm/nouveau/bios: fix shadowing of ACPI ROMs larger than 64KiB
>
> fixes the problem.

Can you test the attached patch too ? I rebased the previous one I sent 
on top on 3.7-rc1 as I accidentally used an older version.

Martin

Comments

Heinz Diehl Oct. 20, 2012, 10:42 a.m. UTC | #1
On 20.10.2012, Martin Peres wrote: 

> Can you test the attached patch too ? I rebased the previous one I sent on
> top on 3.7-rc1 as I accidentally used an older version.

Yes, of course.

Tried it. Unfortunately, the crash remains the same as reported.
Pawe? Sikora Oct. 25, 2012, 5:53 p.m. UTC | #2
On Saturday 20 of October 2012 11:40:04 Martin Peres wrote:
> On 20/10/2012 11:26, Heinz Diehl wrote:
> > On 20.10.2012, Linus Torvalds wrote:
> >
> >> Added more appropriate people to this. Added both i915 and nouveau
> >> people, since apparently that fine piece of hardware has both.
> >>
> >> Guys, any ideas?
> >
> > Plese see https://lkml.org/lkml/2012/10/19/371 , this is the same
> > thing going on. Reverting
> >
> >   Ben Skeggs <bskeggs@redhat.com>
> >   drm/nouveau/bios: fix shadowing of ACPI ROMs larger than 64KiB
> >
> > fixes the problem.
> 
> Can you test the attached patch too ? I rebased the previous one I sent 
> on top on 3.7-rc1 as I accidentally used an older version.
> 
> Martin

Hi all once again,

i've tested current 3.7.0-rc2-00145-g4864ccb and it works fine (boots and works
with builtin core-i7 intel video) but i have one more question - what is the reason
of loading nouveau driver for laptops with nvidia optimus and enabling vga switcheroo
which doesn't work in such (optimus) cases. or maybe i've missed something
and switchereoo works with optimus?

BR,
Pawe?.
Heinz Diehl Oct. 25, 2012, 6:06 p.m. UTC | #3
On 25.10.2012, Pawe? Sikora wrote: 

> what is the reason of loading nouveau driver for laptops 
> with nvidia optimus and enabling vga switcheroo
> which doesn't work in such (optimus) cases.

You can safely compile a kernel without nouveau, your Nvidia 
card will not be used at all since neither Linux nor the 
proprietary nvidia driver does support optimus at this time
(and frankly, I won't buy any further machines with opticrap).
So having nouveau compiled and loaded seems like a waste of ressources
in this case.

For me it's important to have nouveau working, because I try/use
Bumblebee and optirun: 

http://bumblebee-project.org/
https://fedoraproject.org/wiki/Bumblebee
Pawe? Sikora Oct. 26, 2012, 7:51 p.m. UTC | #4
On Thursday 25 of October 2012 20:06:54 Heinz Diehl wrote:
> On 25.10.2012, Pawe? Sikora wrote: 
> 
> > what is the reason of loading nouveau driver for laptops 
> > with nvidia optimus and enabling vga switcheroo
> > which doesn't work in such (optimus) cases.
> 
> You can safely compile a kernel without nouveau, your Nvidia 
> card will not be used at all since neither Linux nor the 
> proprietary nvidia driver does support optimus at this time
> (and frankly, I won't buy any further machines with opticrap).
> So having nouveau compiled and loaded seems like a waste of ressources
> in this case.

i've bought this asus laptop mostly for a developer's workstation replacement
(quad-core-i7-avx cpu with integrated gpu, with 12GB ram and 2x500GB hdd).
nvidia's addon is an optional crap :)

> For me it's important to have nouveau working, because I try/use
> Bumblebee and optirun: 
> 
> http://bumblebee-project.org/
> https://fedoraproject.org/wiki/Bumblebee

i'll try to use transformers too :-)
diff mbox

Patch

From f09d58dc23a6e48ed56a1d9bf803f800f0c59e83 Mon Sep 17 00:00:00 2001
From: Martin Peres <martin.peres@labri.fr>
Date: Sat, 20 Oct 2012 11:03:36 +0200
Subject: [PATCH] drm/nouveau/bios: improve error handling when reading the
 vbios from ACPI

Reported-by: Pawel Sikora <pawel.sikora@agmk.net>
Signed-off-by: Martin Peres <martin.peres@labri.fr>
---
 drivers/gpu/drm/nouveau/core/subdev/bios/base.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/base.c b/drivers/gpu/drm/nouveau/core/subdev/bios/base.c
index 619e7e0..519a3b3 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/bios/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bios/base.c
@@ -188,8 +188,10 @@  nouveau_bios_shadow_acpi(struct nouveau_bios *bios)
 	int ret, cnt, i;
 	u8  data[3];
 
-	if (!nouveau_acpi_rom_supported(pdev))
+	if (!nouveau_acpi_rom_supported(pdev)) {
+		bios->data = NULL;
 		return;
+	}
 
 	bios->size = 0;
 	if (nouveau_acpi_get_bios_chunk(data, 0, 3) == 3)
-- 
1.7.12.4