diff mbox

[3/4] Use autoreconf in autogen.sh

Message ID 1364994415-8330-3-git-send-email-jsquyres@cisco.com (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Jeff Squyres April 3, 2013, 1:06 p.m. UTC 
The old sequence of Autotools commands listed in autogen.sh is no
longer correct.  Instead, just use the single "autoreconf" command,
which will invoke all the Right Autotools commands in the correct
order.

---
 autogen.sh | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Jeff Squyres April 8, 2013, 9:59 p.m. UTC | #1 
Roland --

If there are no objections, can this patch (and patch 4 of this set: https://patchwork.kernel.org/patch/2387321/) be committed?  Neither should not have any real impact other than the modernization of the libibverbs build system.


On Apr 3, 2013, at 9:06 AM, Jeff Squyres <jsquyres@cisco.com> wrote:

> The old sequence of Autotools commands listed in autogen.sh is no
> longer correct.  Instead, just use the single "autoreconf" command,
> which will invoke all the Right Autotools commands in the correct
> order.
> 
> ---
> autogen.sh | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/autogen.sh b/autogen.sh
> index fd47839..6c9233e 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -1,8 +1,4 @@
> #! /bin/sh
> 
> set -x
> -aclocal -I config
> -libtoolize --force --copy
> -autoheader
> -automake --foreign --add-missing --copy
> -autoconf
> +autoreconf -ifv -I config
> -- 
> 1.8.1.1
>
Or Gerlitz April 9, 2013, 5:47 a.m. UTC | #2 
On 09/04/2013 00:59, Jeff Squyres (jsquyres) wrote:
> Roland -- If there are no objections, can this patch (and patch 4 of this set: https://patchwork.kernel.org/patch/2387321/) be committed?  Neither should not have any real impact other than the modernization of the libibverbs build system.

Jeff, the patches don't carry signed-of-by signature line... I would 
suggest you resubmit patches 3 and 4 with a signature

Or.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/autogen.sh b/autogen.sh
index fd47839..6c9233e 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,8 +1,4 @@ 
 #! /bin/sh
 
 set -x
-aclocal -I config
-libtoolize --force --copy
-autoheader
-automake --foreign --add-missing --copy
-autoconf
+autoreconf -ifv -I config