diff mbox

[v2,2/2] mac80211: minstrel_ht: initialize rates selection

Message ID 1366287981-24134-2-git-send-email-karl.beldan@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Karl Beldan April 18, 2013, 12:26 p.m. UTC
From: Karl Beldan <karl.beldan@rivierawaves.com>

Initialize {mp,mi}->{max_tp_rate,max_tp_rate2,max_prob_rate} in
minstrel_ht's rate_init and rate_update.

Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
---
 net/mac80211/rc80211_minstrel_ht.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Karl Beldan April 18, 2013, 12:40 p.m. UTC | #1
Johannes, Felix,

This seems to me like an important enough issue to IMHO, make it into
3.9/-stable. But since we only have a few days before Linus tags the 3.9
I understand the boldness of the thought.
 
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Felix Fietkau April 18, 2013, 1:04 p.m. UTC | #2
On 2013-04-18 2:40 PM, Karl Beldan wrote:
> Johannes, Felix,
> 
> This seems to me like an important enough issue to IMHO, make it into
> 3.9/-stable. But since we only have a few days before Linus tags the 3.9
> I understand the boldness of the thought.
I'm not sure it's important enough for 3.9. Is disabling MCS0 really
that common?

- Felix

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Karl Beldan April 18, 2013, 1:10 p.m. UTC | #3
On Thu, Apr 18, 2013 at 03:04:03PM +0200, Felix Fietkau wrote:
> On 2013-04-18 2:40 PM, Karl Beldan wrote:
> > Johannes, Felix,
> > 
> > This seems to me like an important enough issue to IMHO, make it into
> > 3.9/-stable. But since we only have a few days before Linus tags the 3.9
> > I understand the boldness of the thought.
> I'm not sure it's important enough for 3.9. Is disabling MCS0 really
> that common?
> 
Right.
 
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johannes Berg April 18, 2013, 1:36 p.m. UTC | #4
On Thu, 2013-04-18 at 14:40 +0200, Karl Beldan wrote:
> Johannes, Felix,
> 
> This seems to me like an important enough issue to IMHO, make it into
> 3.9/-stable. But since we only have a few days before Linus tags the 3.9
> I understand the boldness of the thought.

I'm not going to try for 3.9, it wouldn't happen anyway, but if you want
to tag them as Cc stable it's your call. I'm not familiar enough with
the code to really be able to judge the impact I guess. It seems
unlikely to me though that some device would support MCS 1 but not MCS
0, or MCS 9 but not 8, etc.?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Karl Beldan April 18, 2013, 1:46 p.m. UTC | #5
On Thu, Apr 18, 2013 at 03:36:39PM +0200, Johannes Berg wrote:
> On Thu, 2013-04-18 at 14:40 +0200, Karl Beldan wrote:
> > Johannes, Felix,
> > 
> > This seems to me like an important enough issue to IMHO, make it into
> > 3.9/-stable. But since we only have a few days before Linus tags the 3.9
> > I understand the boldness of the thought.
> 
> I'm not going to try for 3.9, it wouldn't happen anyway, but if you want
> to tag them as Cc stable it's your call. I'm not familiar enough with
> the code to really be able to judge the impact I guess. It seems
> unlikely to me though that some device would support MCS 1 but not MCS
> 0, or MCS 9 but not 8, etc.?
> 
I imagined devices that would have their -supported MCSes configure their
hw- that for any reason would not "handle" other ones.
I don't know why I deemed it that important, and agree with you and
Felix ;)

 
Karl
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index eb6dc3f..5768cc0 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -907,6 +907,9 @@  minstrel_ht_update_caps(void *priv, struct ieee80211_supported_band *sband,
 	if (!n_supported)
 		goto use_legacy;
 
+	/* init {mi,mi->groups[*]}->{max_tp_rate,max_tp_rate2,max_prob_rate} */
+	minstrel_ht_update_stats(mp, mi);
+
 	return;
 
 use_legacy: