diff mbox

[3/5] media: i2c: tvp7002: rearrange header inclusion alphabetically

Message ID 1368528334-13595-4-git-send-email-prabhakar.csengg@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Prabhakar May 14, 2013, 10:45 a.m. UTC
From: Lad, Prabhakar <prabhakar.csengg@gmail.com>

This patch rearranges the header inclusion alphabetically
and also removes unnecessary includes.

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-kernel@vger.kernel.org
Cc: davinci-linux-open-source@linux.davincidsp.com
---
 drivers/media/i2c/tvp7002.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

Comments

Hans Verkuil May 23, 2013, 9:35 a.m. UTC | #1
On Tue 14 May 2013 12:45:32 Lad Prabhakar wrote:
> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> 
> This patch rearranges the header inclusion alphabetically
> and also removes unnecessary includes.

As Laurent mentioned in a review for another patch (vpif) you probably
shouldn't remove these headers. videodev2.h is certainly used, as is slab.h
and v4l2-common.h. In the past removing slab.h causes problems on other
architectures where that header isn't automatically included by other
headers.

I would just drop this patch. I've merged the first two patches of
this patch series, the last two I can't merge as long as the async
code isn't in yet.

Regards,

	Hans

> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Sakari Ailus <sakari.ailus@iki.fi>
> Cc: linux-kernel@vger.kernel.org
> Cc: davinci-linux-open-source@linux.davincidsp.com
> ---
>  drivers/media/i2c/tvp7002.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
> index f339e6f..f4114bf 100644
> --- a/drivers/media/i2c/tvp7002.c
> +++ b/drivers/media/i2c/tvp7002.c
> @@ -24,17 +24,17 @@
>   * along with this program; if not, write to the Free Software
>   * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>   */
> +
>  #include <linux/delay.h>
>  #include <linux/i2c.h>
> -#include <linux/slab.h>
> -#include <linux/videodev2.h>
>  #include <linux/module.h>
>  #include <linux/v4l2-dv-timings.h>
> +
>  #include <media/tvp7002.h>
> -#include <media/v4l2-device.h>
>  #include <media/v4l2-chip-ident.h>
> -#include <media/v4l2-common.h>
>  #include <media/v4l2-ctrls.h>
> +#include <media/v4l2-device.h>
> +
>  #include "tvp7002_reg.h"
>  
>  MODULE_DESCRIPTION("TI TVP7002 Video and Graphics Digitizer driver");
>
Prabhakar May 23, 2013, 9:41 a.m. UTC | #2
Hi Hans,

On Thu, May 23, 2013 at 3:05 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On Tue 14 May 2013 12:45:32 Lad Prabhakar wrote:
>> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>>
>> This patch rearranges the header inclusion alphabetically
>> and also removes unnecessary includes.
>
> As Laurent mentioned in a review for another patch (vpif) you probably
> shouldn't remove these headers. videodev2.h is certainly used, as is slab.h
> and v4l2-common.h. In the past removing slab.h causes problems on other
> architectures where that header isn't automatically included by other
> headers.
>
OK

> I would just drop this patch. I've merged the first two patches of
> this patch series, the last two I can't merge as long as the async
> code isn't in yet.
>
Thanks. yes the last two depend on v4l-async patches.

Regards,
--Prabhakar Lad
diff mbox

Patch

diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
index f339e6f..f4114bf 100644
--- a/drivers/media/i2c/tvp7002.c
+++ b/drivers/media/i2c/tvp7002.c
@@ -24,17 +24,17 @@ 
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
+
 #include <linux/delay.h>
 #include <linux/i2c.h>
-#include <linux/slab.h>
-#include <linux/videodev2.h>
 #include <linux/module.h>
 #include <linux/v4l2-dv-timings.h>
+
 #include <media/tvp7002.h>
-#include <media/v4l2-device.h>
 #include <media/v4l2-chip-ident.h>
-#include <media/v4l2-common.h>
 #include <media/v4l2-ctrls.h>
+#include <media/v4l2-device.h>
+
 #include "tvp7002_reg.h"
 
 MODULE_DESCRIPTION("TI TVP7002 Video and Graphics Digitizer driver");