| Message ID | fd299c9ef87fe50c12af871d6bfcc92d7f6ef3dc.1370356776.git.joe@perches.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue, Jun 04, 2013 at 07:44:50AM -0700, Joe Perches wrote: > goto after return is wrong. > > The other code in this block needs to set an > error value then goto an error release block. > > This one doesn't need to release anything and > was likely a copy/paste remainder. > > Signed-off-by: Joe Perches <joe@perches.com> Acked-By: Solomon Peachy <pizza@shaftnet.org> > --- > drivers/net/wireless/cw1200/hwio.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/cw1200/hwio.c b/drivers/net/wireless/cw1200/hwio.c > index 142f45ef..dad3fb3 100644 > --- a/drivers/net/wireless/cw1200/hwio.c > +++ b/drivers/net/wireless/cw1200/hwio.c > @@ -178,7 +178,6 @@ int cw1200_indirect_read(struct cw1200_common *priv, u32 addr, void *buf, > if ((buf_len / 2) >= 0x1000) { > pr_err("Can't read more than 0xfff words.\n"); > return -EINVAL; > - goto out; > } > > priv->hwbus_ops->lock(priv->hwbus_priv); > -- > 1.8.1.2.459.gbcd45b4.dirty > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/cw1200/hwio.c b/drivers/net/wireless/cw1200/hwio.c index 142f45ef..dad3fb3 100644 --- a/drivers/net/wireless/cw1200/hwio.c +++ b/drivers/net/wireless/cw1200/hwio.c @@ -178,7 +178,6 @@ int cw1200_indirect_read(struct cw1200_common *priv, u32 addr, void *buf, if ((buf_len / 2) >= 0x1000) { pr_err("Can't read more than 0xfff words.\n"); return -EINVAL; - goto out; } priv->hwbus_ops->lock(priv->hwbus_priv);
goto after return is wrong. The other code in this block needs to set an error value then goto an error release block. This one doesn't need to release anything and was likely a copy/paste remainder. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/wireless/cw1200/hwio.c | 1 - 1 file changed, 1 deletion(-)