diff mbox

[libibverbs] Fix configure regression that disallowed building on older systems

Message ID 1373538859-32636-1-git-send-email-ogerlitz@r-vnc04.mtr.labs.mlnx (mailing list archive)
State Rejected
Headers show

Commit Message

Or Gerlitz July 11, 2013, 10:34 a.m. UTC 
From: Or Gerlitz <ogerlitz@mellanox.com>

Commit 9bbd803 "configure: Apply updates proposed by autoupdate" forced
the autoconf package on the builder node to be of version 2.67 or higher.

This doesn't allow to build the library e.g on RHEL 6.x systems
who install this set of tools

	autofs-5.0.5-39.el6.x86_64
	automake-1.11.1-1.2.el6.noarch
	autoconf-2.63-5.1.el6.noarch

Be a bit more conservative and require 2.63 or higher.

CC: Yann Droneaud <ydroneaud@opteya.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Yann Droneaud July 11, 2013, 11:03 a.m. UTC | #1 
Le 11.07.2013 12:34, Or Gerlitz a écrit :
> From: Or Gerlitz <ogerlitz@mellanox.com>
> 
> Commit 9bbd803 "configure: Apply updates proposed by autoupdate" forced
> the autoconf package on the builder node to be of version 2.67 or 
> higher.
> 
> This doesn't allow to build the library e.g on RHEL 6.x systems
> who install this set of tools
> 
> 	autofs-5.0.5-39.el6.x86_64
> 	automake-1.11.1-1.2.el6.noarch
> 	autoconf-2.63-5.1.el6.noarch
> 
> Be a bit more conservative and require 2.63 or higher.
> 

If the "release" tarball is used, the library should build regardless
of the installed autoconf/automake.

I warned about that when the patch was submitted :)

- http://article.gmane.org/gmane.linux.drivers.rdma/15724

"
It works on Debian 6.0 (Squeeze) and Fedora 17 (Beefy Miracle),
but you might want to test on older systems ... I'm looking at you
Red Hat Enterprise Linux ... But ultimately it depends on the
release manager's host environment which is probably up to date :)
"

> CC: Yann Droneaud <ydroneaud@opteya.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Acked-By: Yann Droneaud <ydroneaud@opteya.com>


Regards
Or Gerlitz July 11, 2013, 12:01 p.m. UTC | #2 
On 11/07/2013 14:03, Yann Droneaud wrote:
> If the "release" tarball is used, the library should build regardless
> of the installed autoconf/automake.
indeed, but when we d/d (develop/debug) with the library we should be 
able to build it through simple configure and make
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jason Gunthorpe July 11, 2013, 4:58 p.m. UTC | #3 
On Thu, Jul 11, 2013 at 03:01:09PM +0300, Or Gerlitz wrote:
> On 11/07/2013 14:03, Yann Droneaud wrote:
> >If the "release" tarball is used, the library should build regardless
> >of the installed autoconf/automake.

> indeed, but when we d/d (develop/debug) with the library we should
> be able to build it through simple configure and make

You could install a modern autoconf/etc on your devel work stations?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index b8d4cea..32af774 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,6 +1,6 @@ 
 dnl Process this file with autoconf to produce a configure script.
 
-AC_PREREQ([2.67])
+AC_PREREQ([2.63])
 AC_INIT([libibverbs],[1.1.7],[linux-rdma@vger.kernel.org])
 AC_CONFIG_SRCDIR([src/ibverbs.h])
 AC_CONFIG_AUX_DIR(config)