| Message ID | CAPgLHd917tqPE=CBP0OezF=v+M61GY=cUX-GTUbUKYhoeoj3hQ@mail.gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
Looks to me like a convenience that we may need to give up later should we need to put any code in the init or cleanup functions. On Wed, Jul 17, 2013 at 09:56:41AM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Use the module_pci_driver() macro to make the code simpler > by eliminating module_init and module_exit calls. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/infiniband/hw/mlx5/main.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c > index 8000fff..0cdc185 100644 > --- a/drivers/infiniband/hw/mlx5/main.c > +++ b/drivers/infiniband/hw/mlx5/main.c > @@ -1490,15 +1490,4 @@ static struct pci_driver mlx5_ib_driver = { > .remove = remove_one > }; > > -static int __init mlx5_ib_init(void) > -{ > - return pci_register_driver(&mlx5_ib_driver); > -} > - > -static void __exit mlx5_ib_cleanup(void) > -{ > - pci_unregister_driver(&mlx5_ib_driver); > -} > - > -module_init(mlx5_ib_init); > -module_exit(mlx5_ib_cleanup); > +module_pci_driver(mlx5_ib_driver); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index 8000fff..0cdc185 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -1490,15 +1490,4 @@ static struct pci_driver mlx5_ib_driver = { .remove = remove_one }; -static int __init mlx5_ib_init(void) -{ - return pci_register_driver(&mlx5_ib_driver); -} - -static void __exit mlx5_ib_cleanup(void) -{ - pci_unregister_driver(&mlx5_ib_driver); -} - -module_init(mlx5_ib_init); -module_exit(mlx5_ib_cleanup); +module_pci_driver(mlx5_ib_driver);