diff mbox

PCI: mvebu: make Marvell PCIe driver depend on OF

Message ID 1376044550-30572-1-git-send-email-thomas.petazzoni@free-electrons.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Thomas Petazzoni Aug. 9, 2013, 10:35 a.m. UTC
The Marvell PCIe host controller driver is heavily tied to Device Tree
APIs, and can only be used on platforms where the Device Tree is
used. Therefore, it should "depends on OF" to avoid build failures on
!OF configurations.

Reported-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Bjorn, you can take this one through your tree. Either for 3.11 or
3.12, at your preference.
---
 drivers/pci/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Ezequiel Garcia Aug. 9, 2013, 11:38 a.m. UTC | #1
On Fri, Aug 09, 2013 at 12:35:50PM +0200, Thomas Petazzoni wrote:
> The Marvell PCIe host controller driver is heavily tied to Device Tree
> APIs, and can only be used on platforms where the Device Tree is
> used. Therefore, it should "depends on OF" to avoid build failures on
> !OF configurations.
> 
> Reported-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

> ---
> Bjorn, you can take this one through your tree. Either for 3.11 or
> 3.12, at your preference.
> ---
>  drivers/pci/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 1184ff6..e5ba4eb 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -4,6 +4,7 @@ menu "PCI host controller drivers"
>  config PCI_MVEBU
>  	bool "Marvell EBU PCIe controller"
>  	depends on ARCH_MVEBU || ARCH_KIRKWOOD
> +	depends on OF
>  
>  config PCIE_DW
>  	bool
> -- 
> 1.8.1.2
>
Bjorn Helgaas Aug. 9, 2013, 5:08 p.m. UTC | #2
On Fri, Aug 09, 2013 at 12:35:50PM +0200, Thomas Petazzoni wrote:
> The Marvell PCIe host controller driver is heavily tied to Device Tree
> APIs, and can only be used on platforms where the Device Tree is
> used. Therefore, it should "depends on OF" to avoid build failures on
> !OF configurations.
> 
> Reported-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Bjorn, you can take this one through your tree. Either for 3.11 or
> 3.12, at your preference.

Applied to pci/misc for v3.12, thanks!

> ---
>  drivers/pci/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 1184ff6..e5ba4eb 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -4,6 +4,7 @@ menu "PCI host controller drivers"
>  config PCI_MVEBU
>  	bool "Marvell EBU PCIe controller"
>  	depends on ARCH_MVEBU || ARCH_KIRKWOOD
> +	depends on OF
>  
>  config PCIE_DW
>  	bool
> -- 
> 1.8.1.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index 1184ff6..e5ba4eb 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -4,6 +4,7 @@  menu "PCI host controller drivers"
 config PCI_MVEBU
 	bool "Marvell EBU PCIe controller"
 	depends on ARCH_MVEBU || ARCH_KIRKWOOD
+	depends on OF
 
 config PCIE_DW
 	bool