| Message ID | 1376189294-32022-26-git-send-email-yinghai@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Sat, Aug 10, 2013 at 07:48:11PM -0700, Yinghai Lu wrote: > ioapic hotplug should be built-in like pci root bus hotplug. > > Also need to make it depends on X86_IO_APIC. > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> Hi Yinghai, What's the status of these? It looks like the last three or four could go via my PCI tree, but I don't know whether they depend on the earlier patches. If they could be applied separately, I could merge them and we could make *some* progress. Also, it looks like you planned some rework related to _UID and resource parsing, so I've been waiting for that to show up before doing much more. Bjorn > --- > drivers/pci/Kconfig | 3 ++- > drivers/pci/ioapic.c | 6 +++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig > index 81944fb..6c9ede2 100644 > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > @@ -109,9 +109,10 @@ config PCI_PASID > If unsure, say N. > > config PCI_IOAPIC > - tristate "PCI IO-APIC hotplug support" if X86 > + bool "PCI IO-APIC hotplug support" if X86 > depends on PCI > depends on ACPI > + depends on X86_IO_APIC > default !X86 > > config PCI_LABEL > diff --git a/drivers/pci/ioapic.c b/drivers/pci/ioapic.c > index 1b90579..7d6b157 100644 > --- a/drivers/pci/ioapic.c > +++ b/drivers/pci/ioapic.c > @@ -113,6 +113,10 @@ static struct pci_driver ioapic_driver = { > .remove = ioapic_remove, > }; > > -module_pci_driver(ioapic_driver); > +static int __init ioapic_init(void) > +{ > + return pci_register_driver(&ioapic_driver); > +} > +module_init(ioapic_init); > > MODULE_LICENSE("GPL"); > -- > 1.8.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Oct 1, 2013 at 9:00 AM, Bjorn Helgaas <bhelgaas@google.com> wrote: > On Sat, Aug 10, 2013 at 07:48:11PM -0700, Yinghai Lu wrote: >> ioapic hotplug should be built-in like pci root bus hotplug. >> >> Also need to make it depends on X86_IO_APIC. >> >> Signed-off-by: Yinghai Lu <yinghai@kernel.org> > > Hi Yinghai, > > What's the status of these? It looks like the last three or four > could go via my PCI tree, but I don't know whether they depend on > the earlier patches. If they could be applied separately, I could > merge them and we could make *some* progress. they are rely on other patches. would be better if you give them ack, and let them via tip/x86/irq etc. or in two parts: after first part go to upstream via tip, and we can push left pci related via pci tree. > > Also, it looks like you planned some rework related to _UID and > resource parsing, so I've been waiting for that to show up before > doing much more. yes, I have that ready. will post them shortly. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig index 81944fb..6c9ede2 100644 --- a/drivers/pci/Kconfig +++ b/drivers/pci/Kconfig @@ -109,9 +109,10 @@ config PCI_PASID If unsure, say N. config PCI_IOAPIC - tristate "PCI IO-APIC hotplug support" if X86 + bool "PCI IO-APIC hotplug support" if X86 depends on PCI depends on ACPI + depends on X86_IO_APIC default !X86 config PCI_LABEL diff --git a/drivers/pci/ioapic.c b/drivers/pci/ioapic.c index 1b90579..7d6b157 100644 --- a/drivers/pci/ioapic.c +++ b/drivers/pci/ioapic.c @@ -113,6 +113,10 @@ static struct pci_driver ioapic_driver = { .remove = ioapic_remove, }; -module_pci_driver(ioapic_driver); +static int __init ioapic_init(void) +{ + return pci_register_driver(&ioapic_driver); +} +module_init(ioapic_init); MODULE_LICENSE("GPL");
ioapic hotplug should be built-in like pci root bus hotplug. Also need to make it depends on X86_IO_APIC. Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- drivers/pci/Kconfig | 3 ++- drivers/pci/ioapic.c | 6 +++++- 2 files changed, 7 insertions(+), 2 deletions(-)