| Message ID | 1382550852-11508-3-git-send-email-sre@debian.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2013-10-23 at 19:54 +0200, Sebastian Reichel wrote: > Use dev_err() to output errors instead of dev_dbg(). [] > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c [] > @@ -60,7 +60,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) > > pwr = input_allocate_device(); > if (!pwr) { > - dev_dbg(&pdev->dev, "Can't allocate power button\n"); > + dev_err(&pdev->dev, "Can't allocate power button\n"); > return -ENOMEM; > } input_allocate_device uses kzalloc and it will emit a standardized OOM message along with a dump_stack() so this dev_err/dev_dbg is redundant and not necessary. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Oct 23, 2013 at 11:17:46AM -0700, Joe Perches wrote: > On Wed, 2013-10-23 at 19:54 +0200, Sebastian Reichel wrote: > > Use dev_err() to output errors instead of dev_dbg(). > [] > > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c > [] > > @@ -60,7 +60,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) > > > > pwr = input_allocate_device(); > > if (!pwr) { > > - dev_dbg(&pdev->dev, "Can't allocate power button\n"); > > + dev_err(&pdev->dev, "Can't allocate power button\n"); > > return -ENOMEM; > > } > > input_allocate_device uses kzalloc and it will emit a > standardized OOM message along with a dump_stack() > so this dev_err/dev_dbg is redundant and not necessary. I saw you sent a big patchset changing this for all drivers. Should I drop this patch? -- Sebastian
On Wed, 2013-10-23 at 21:31 +0200, Sebastian Reichel wrote: > On Wed, Oct 23, 2013 at 11:17:46AM -0700, Joe Perches wrote: > > On Wed, 2013-10-23 at 19:54 +0200, Sebastian Reichel wrote: > > > Use dev_err() to output errors instead of dev_dbg(). > > [] > > > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c > > [] > > > @@ -60,7 +60,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) > > > > > > pwr = input_allocate_device(); > > > if (!pwr) { > > > - dev_dbg(&pdev->dev, "Can't allocate power button\n"); > > > + dev_err(&pdev->dev, "Can't allocate power button\n"); > > > return -ENOMEM; > > > } > > > > input_allocate_device uses kzalloc and it will emit a > > standardized OOM message along with a dump_stack() > > so this dev_err/dev_dbg is redundant and not necessary. > > I saw you sent a big patchset changing this for all drivers. > Should I drop this patch? I think the 2 other bits of this patch are fine. Maybe resend with this section dropped? -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c index a3a0fe3..3efbb13 100644 --- a/drivers/input/misc/twl4030-pwrbutton.c +++ b/drivers/input/misc/twl4030-pwrbutton.c @@ -60,7 +60,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) pwr = input_allocate_device(); if (!pwr) { - dev_dbg(&pdev->dev, "Can't allocate power button\n"); + dev_err(&pdev->dev, "Can't allocate power button\n"); return -ENOMEM; } @@ -74,13 +74,13 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev) IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING, "twl4030_pwrbutton", pwr); if (err < 0) { - dev_dbg(&pdev->dev, "Can't get IRQ for pwrbutton: %d\n", err); + dev_err(&pdev->dev, "Can't get IRQ for pwrbutton: %d\n", err); goto free_input_dev; } err = input_register_device(pwr); if (err) { - dev_dbg(&pdev->dev, "Can't register power button: %d\n", err); + dev_err(&pdev->dev, "Can't register power button: %d\n", err); goto free_irq; }
Use dev_err() to output errors instead of dev_dbg(). Signed-off-by: Sebastian Reichel <sre@debian.org> --- drivers/input/misc/twl4030-pwrbutton.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)