| Message ID | 1384808595-26028-1-git-send-email-yann.morin.1998@free.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 18 Nov 2013 at 22:03, Yann E. MORIN wrote: > Madhavan, Christian, if you could give a bit ;ore details on the distro > you're using, that be nice so we can have a more descriptive commit log. In my case it's gcc-4.7 from Debian/wheezy (powerpc): $ gcc --version | head -1 gcc (Debian 4.7.2-5) 4.7.2 Christian.
On Tuesday 19 November 2013 02:33 AM, Yann E. MORIN wrote: > > Madhavan, Christian, if you could give a bit ;ore details on the distro > you're using, that be nice so we can have a more descriptive commit log. When I initially reported this issue, it was in gcc version 4.8.0 20130526. And I am trying this now in a beta release of RHEL7 with gcc version 4.8.1 20131002 (Red Hat 4.8.1-11) (GCC) and I still see the reported issue. --Maddy -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19.11.2013 08:27, Madhavan Srinivasan wrote: > On Tuesday 19 November 2013 02:33 AM, Yann E. MORIN wrote: >> >> Madhavan, Christian, if you could give a bit ;ore details on the distro >> you're using, that be nice so we can have a more descriptive commit log. > > When I initially reported this issue, it was in gcc version 4.8.0 > 20130526. And I am trying this now in a beta release of RHEL7 with gcc > version 4.8.1 20131002 (Red Hat 4.8.1-11) (GCC) and I still see the > reported issue. In that case, I'd just give up and initialize jump to NULL. Worst case, we will get a segfault at runtime if a genuine bug is introduced into the function. What do you think? Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013/11/19 11:13, Michal Marek wrote: > On 19.11.2013 08:27, Madhavan Srinivasan wrote: > > On Tuesday 19 November 2013 02:33 AM, Yann E. MORIN wrote: > >> > >> Madhavan, Christian, if you could give a bit ;ore details on the distro > >> you're using, that be nice so we can have a more descriptive commit log. > > > > When I initially reported this issue, it was in gcc version 4.8.0 > > 20130526. And I am trying this now in a beta release of RHEL7 with gcc > > version 4.8.1 20131002 (Red Hat 4.8.1-11) (GCC) and I still see the > > reported issue. > > In that case, I'd just give up and initialize jump to NULL. Worst case, > we will get a segfault at runtime if a genuine bug is introduced into > the function. What do you think? I've tried it again on openSUSE 13.1 which has gcc (SUSE Linux) 4.8.1 20130909 [gcc-4_8-branch revision 202388] and I don't see the warning. I may be missing something because I've also tried on Debian Wheezy (as reported by Christian Kujau) but I don't see a warning either. It was on x86 however, not ppc. In any case, given that it's been reported a few times I agree with Michal and I'd do something like this: - struct jump_key *jump; + /* Initialize jump to work around a spurious warning emitted by + * certain versions of gcc */ + struct jump_key *jump = NULL; -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c index c1d5320..a7b0566 100644 --- a/scripts/kconfig/menu.c +++ b/scripts/kconfig/menu.c @@ -544,6 +544,13 @@ static void get_prompt_str(struct gstr *r, struct property *prop, { int i, j; struct menu *submenu[8], *menu, *location = NULL; + /* gcc 4.8.0 on (on some distros) warns about 'jump may be used + uninitialized', which is wrong, given the current code-path. + The warning does not appear with gcc != 4.8.0. + If we were to change the code below, we would still want gcc to + warn if jump is unitialised, so we explicitly do *not* initialise + it here. + */ struct jump_key *jump; str_printf(r, _("Prompt: %s\n"), _(prop->text));