| Message ID | 1389217075-28551-1-git-send-email-cheiny@synaptics.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 08, 2014 at 01:37:55PM -0800, Christopher Heiny wrote: > This is a trivial change to use snprintf rather than sprintf while building > the diagnostic output buffer. > > Signed-off-by: Christopher Heiny <cheiny@synaptics.com> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > --- > > drivers/input/rmi4/rmi_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/rmi4/rmi_i2c.c b/drivers/input/rmi4/rmi_i2c.c > index b33074c..43b0e53 100644 > --- a/drivers/input/rmi4/rmi_i2c.c > +++ b/drivers/input/rmi4/rmi_i2c.c > @@ -157,7 +157,7 @@ static int copy_to_debug_buf(struct device *dev, struct rmi_i2c_data *data, > temp = data->debug_buf; > > for (i = 0; i < len; i++) { > - n = sprintf(temp, " %02x", buf[i]); > + n = snprintf(temp, 3, " %02x", buf[i]); > temp += n; > } > I do not think it is right, as if there is truncation you'd move too far. In any case please replace the while loop with: snprintf(data->debug_buf, data->debug_buf_size, "%*ph", len, buf); Thanks.
diff --git a/drivers/input/rmi4/rmi_i2c.c b/drivers/input/rmi4/rmi_i2c.c index b33074c..43b0e53 100644 --- a/drivers/input/rmi4/rmi_i2c.c +++ b/drivers/input/rmi4/rmi_i2c.c @@ -157,7 +157,7 @@ static int copy_to_debug_buf(struct device *dev, struct rmi_i2c_data *data, temp = data->debug_buf; for (i = 0; i < len; i++) { - n = sprintf(temp, " %02x", buf[i]); + n = snprintf(temp, 3, " %02x", buf[i]); temp += n; }
This is a trivial change to use snprintf rather than sprintf while building the diagnostic output buffer. Signed-off-by: Christopher Heiny <cheiny@synaptics.com> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- drivers/input/rmi4/rmi_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html