| Message ID | 20140207144639.GA10939@dhcp-26-207.brq.redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Friday, February 07, 2014 03:46:40 PM Alexander Gordeev wrote: > This update fixes a warning introduced with commit bc977ba1 > ("wil6210: Use pci_enable_msi_range() instead of pci_enable_msi_block()") > > drivers/net/wireless/ath/wil6210/pcie_bus.c:65 wil_if_pcie_enable() > warn: missing break? reassigning 'use_msi' > I can't reproduce this warning. What tools used to get it? Neither gcc (I have 4.8.1) nor sparse report it. Anyway, I am fine with both 'switch' and 'if'. Thanks, Vladimir. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 10, 2014 at 12:54:13PM +0200, Vladimir Kondratiev wrote:
> I can't reproduce this warning. What tools used to get it?
Fengguang?
Hi Alexander, On Mon, Feb 10, 2014 at 01:16:38PM +0100, Alexander Gordeev wrote: > On Mon, Feb 10, 2014 at 12:54:13PM +0200, Vladimir Kondratiev wrote: > > I can't reproduce this warning. What tools used to get it? > > Fengguang? This is a smatch warning: http://smatch.sourceforge.net/ Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ath/wil6210/pcie_bus.c b/drivers/net/wireless/ath/wil6210/pcie_bus.c index 4e1bf54..e1c8cc4 100644 --- a/drivers/net/wireless/ath/wil6210/pcie_bus.c +++ b/drivers/net/wireless/ath/wil6210/pcie_bus.c @@ -51,16 +51,12 @@ static int wil_if_pcie_enable(struct wil6210_priv *wil) use_msi = 1; } - switch (use_msi) { - case 3: - if (pci_enable_msi_range(pdev, 3, 3) > 0) - break; + if (use_msi == 3 && pci_enable_msi_range(pdev, 3, 3) < 0) { wil_err(wil, "3 MSI mode failed, try 1 MSI\n"); use_msi = 1; - /* fallthrough */ - case 1: - if (!pci_enable_msi(pdev)) - break; + } + + if (use_msi == 1 && pci_enable_msi(pdev)) { wil_err(wil, "pci_enable_msi failed, use INTx\n"); use_msi = 0; }
This update fixes a warning introduced with commit bc977ba1 ("wil6210: Use pci_enable_msi_range() instead of pci_enable_msi_block()") drivers/net/wireless/ath/wil6210/pcie_bus.c:65 wil_if_pcie_enable() warn: missing break? reassigning 'use_msi' Signed-off-by: Alexander Gordeev <agordeev@redhat.com> --- drivers/net/wireless/ath/wil6210/pcie_bus.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-)