diff mbox

KVM: fix lock imbalance

Message ID 1246291510-3676-1-git-send-email-jirislaby@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jiri Slaby June 29, 2009, 4:05 p.m. UTC 
There is a missing unlock on one fail path in ioapic_mmio_write,
fix that.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
 virt/kvm/ioapic.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Avi Kivity July 1, 2009, 8:17 a.m. UTC | #1 
On 06/29/2009 07:05 PM, Jiri Slaby wrote:
> There is a missing unlock on one fail path in ioapic_mmio_write,
> fix that.
>    

Applied, thanks.
diff mbox

Patch

diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
index d8b2eca..2b3307b 100644
--- a/virt/kvm/ioapic.c
+++ b/virt/kvm/ioapic.c
@@ -290,7 +290,7 @@  static void ioapic_mmio_write(struct kvm_io_device *this, gpa_t addr, int len,
 		data = *(u32 *) val;
 	else {
 		printk(KERN_WARNING "ioapic: Unsupported size %d\n", len);
-		return;
+		goto unlock;
 	}
 
 	addr &= 0xff;
@@ -311,6 +311,7 @@  static void ioapic_mmio_write(struct kvm_io_device *this, gpa_t addr, int len,
 	default:
 		break;
 	}
+unlock:
 	mutex_unlock(&ioapic->kvm->irq_lock);
 }