| Message ID | 20140221165809.GI17353@dhcp-26-207.brq.redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Fri, 21 Feb 2014, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: linux-pci@vger.kernel.org > --- > drivers/mfd/timberdale.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks.
> > As result of deprecation of MSI-X/MSI enablement functions > > pci_enable_msix() and pci_enable_msi_block() all drivers > > using these two interfaces need to be updated to use the > > new pci_enable_msi_range() or pci_enable_msi_exact() > > and pci_enable_msix_range() or pci_enable_msix_exact() > > interfaces. > > > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > > Cc: Samuel Ortiz <sameo@linux.intel.com> > > Cc: Lee Jones <lee.jones@linaro.org> > > Cc: linux-pci@vger.kernel.org > > --- > > drivers/mfd/timberdale.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > Applied, thanks. I've reverted this patch, as it doesn't build othognally. drivers/mfd/timberdale.c:718:2: error: implicit declaration of function ‘pci_enable_msix_exact’ [-Werror=implicit-function-declaration]
On Mon, Mar 03, 2014 at 03:25:51PM +0800, Lee Jones wrote: > > Applied, thanks. > > I've reverted this patch, as it doesn't build othognally. > > drivers/mfd/timberdale.c:718:2: > error: implicit declaration of function ‘pci_enable_msix_exact’ > [-Werror=implicit-function-declaration] I should have to clarify it I think. Do you build on top of 3.14-rc4? Thanks!
> > > Applied, thanks. > > > > I've reverted this patch, as it doesn't build othognally. > > > > drivers/mfd/timberdale.c:718:2: > > error: implicit declaration of function ‘pci_enable_msix_exact’ > > [-Werror=implicit-function-declaration] > > I should have to clarify it I think. Do you build on top of 3.14-rc4? Not yet. Is the required patch in there?
On Mon, Mar 03, 2014 at 05:26:00PM +0800, Lee Jones wrote: > > > > Applied, thanks. > > > > > > I've reverted this patch, as it doesn't build othognally. > > > > > > drivers/mfd/timberdale.c:718:2: > > > error: implicit declaration of function ‘pci_enable_msix_exact’ > > > [-Werror=implicit-function-declaration] > > > > I should have to clarify it I think. Do you build on top of 3.14-rc4? > > Not yet. Is the required patch in there? Yep - commit 302a252 ("PCI/MSI: Add pci_enable_msi_range() and pci_enable_msix_range()").
> > > > > Applied, thanks. > > > > > > > > I've reverted this patch, as it doesn't build othognally. > > > > > > > > drivers/mfd/timberdale.c:718:2: > > > > error: implicit declaration of function ‘pci_enable_msix_exact’ > > > > [-Werror=implicit-function-declaration] > > > > > > I should have to clarify it I think. Do you build on top of 3.14-rc4? > > > > Not yet. Is the required patch in there? > > Yep - commit 302a252 ("PCI/MSI: Add pci_enable_msi_range() and > pci_enable_msix_range()"). Okay, seems to work fine post-rebase. Reapplied, thanks.
diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c index 2bc5cfb..6ce36d6 100644 --- a/drivers/mfd/timberdale.c +++ b/drivers/mfd/timberdale.c @@ -715,7 +715,7 @@ static int timb_probe(struct pci_dev *dev, for (i = 0; i < TIMBERDALE_NR_IRQS; i++) msix_entries[i].entry = i; - err = pci_enable_msix(dev, msix_entries, TIMBERDALE_NR_IRQS); + err = pci_enable_msix_exact(dev, msix_entries, TIMBERDALE_NR_IRQS); if (err) { dev_err(&dev->dev, "MSI-X init failed: %d, expected entries: %d\n",
As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> Cc: Samuel Ortiz <sameo@linux.intel.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: linux-pci@vger.kernel.org --- drivers/mfd/timberdale.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)