diff mbox

staging: rtl8723au: fix some confusing indenting

Message ID 20140503201919.GB32753@mwanda (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Dan Carpenter May 3, 2014, 8:19 p.m. UTC
The break and the "unknown++" are at the same indent level so my static
checker complains.  The if statement should be indented more.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jes Sorensen May 3, 2014, 9:09 p.m. UTC | #1
Dan Carpenter <dan.carpenter@oracle.com> writes:
> The break and the "unknown++" are at the same indent level so my static
> checker complains.  The if statement should be indented more.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Urgh yes, that should be cleaned up!

Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index eb7b98e..4ad80e7 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
>  		case WLAN_EID_ERP_INFO:
>  		case WLAN_EID_EXT_SUPP_RATES:
>  		case WLAN_EID_VENDOR_SPECIFIC:
> -		if (rtw_validate_vendor_specific_ies(pos, elen))
> -			unknown++;
> +			if (rtw_validate_vendor_specific_ies(pos, elen))
> +				unknown++;
>  			break;
>  		case WLAN_EID_RSN:
>  		case WLAN_EID_PWR_CAPABILITY:
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index eb7b98e..4ad80e7 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
@@ -1235,8 +1235,8 @@  static int rtw_validate_frame_ies(const u8 *start, uint len)
 		case WLAN_EID_ERP_INFO:
 		case WLAN_EID_EXT_SUPP_RATES:
 		case WLAN_EID_VENDOR_SPECIFIC:
-		if (rtw_validate_vendor_specific_ies(pos, elen))
-			unknown++;
+			if (rtw_validate_vendor_specific_ies(pos, elen))
+				unknown++;
 			break;
 		case WLAN_EID_RSN:
 		case WLAN_EID_PWR_CAPABILITY: