diff mbox

[10/20] wireless: group Broadcom wireless drivers on kconfig

Message ID 1250191909-21682-11-git-send-email-lrodriguez@atheros.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Luis Rodriguez Aug. 13, 2009, 7:31 p.m. UTC
Cc: Michael Buesch <mb@bu3sch.de>
Cc: Gábor Stefanik <netrolller.3d@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
 drivers/net/wireless/Kconfig |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

Comments

Johannes Berg Aug. 13, 2009, 7:39 p.m. UTC | #1
On Thu, 2009-08-13 at 15:31 -0400, Luis R. Rodriguez wrote:
> Cc: Michael Buesch <mb@bu3sch.de>
> Cc: Gábor Stefanik <netrolller.3d@gmail.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
>  drivers/net/wireless/Kconfig |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
> index 65397fe..1a8e9bd 100644
> --- a/drivers/net/wireless/Kconfig
> +++ b/drivers/net/wireless/Kconfig
> @@ -378,6 +378,14 @@ config USB_ZD1201
>  
>  endif # ZYDAS_80211
>  
> +menuconfig BROADCOM_80211
> +	bool "Broadcom Wireless Cards"
> +	depends on WLAN_80211
> +	---help---
> +	  This will enable the support for Broadcom wireless drivers. This
> +	  includes b43 driver, b43legacy driver and the rndis_wlan driver.

Ok ... so what's the point of all these patches?

Also, I don't think rndis wlan is always broadcom, and in an case it's
almost never marked as such.

johannes
Luis Rodriguez Aug. 13, 2009, 7:46 p.m. UTC | #2
On Thu, Aug 13, 2009 at 12:39 PM, Johannes
Berg<johannes@sipsolutions.net> wrote:
> On Thu, 2009-08-13 at 15:31 -0400, Luis R. Rodriguez wrote:
>> Cc: Michael Buesch <mb@bu3sch.de>
>> Cc: Gábor Stefanik <netrolller.3d@gmail.com>
>> Cc: Johannes Berg <johannes@sipsolutions.net>
>> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>> ---
>>  drivers/net/wireless/Kconfig |   10 ++++++++++
>>  1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
>> index 65397fe..1a8e9bd 100644
>> --- a/drivers/net/wireless/Kconfig
>> +++ b/drivers/net/wireless/Kconfig
>> @@ -378,6 +378,14 @@ config USB_ZD1201
>>
>>  endif # ZYDAS_80211
>>
>> +menuconfig BROADCOM_80211
>> +     bool "Broadcom Wireless Cards"
>> +     depends on WLAN_80211
>> +     ---help---
>> +       This will enable the support for Broadcom wireless drivers. This
>> +       includes b43 driver, b43legacy driver and the rndis_wlan driver.
>
> Ok ... so what's the point of all these patches?

Its stated on 0/20.

> Also, I don't think rndis wlan is always broadcom, and in an case it's
> almost never marked as such.

From the rndis_wlan kconfig:

          "All of these devices are based on Broadcom 4320 chip which is the
          only wireless RNDIS chip known to date."

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johannes Berg Aug. 13, 2009, 7:54 p.m. UTC | #3
On Thu, 2009-08-13 at 12:46 -0700, Luis R. Rodriguez wrote:

> > Also, I don't think rndis wlan is always broadcom, and in an case it's
> > almost never marked as such.
> 
> From the rndis_wlan kconfig:
> 
>           "All of these devices are based on Broadcom 4320 chip which is the
>           only wireless RNDIS chip known to date."

Yeah, but it's more of a spec. Anyway I guess that doesn't matter much.

johannes
Luis Rodriguez Aug. 13, 2009, 8:04 p.m. UTC | #4
On Thu, Aug 13, 2009 at 12:54 PM, Johannes
Berg<johannes@sipsolutions.net> wrote:
> On Thu, 2009-08-13 at 12:46 -0700, Luis R. Rodriguez wrote:
>
>> > Also, I don't think rndis wlan is always broadcom, and in an case it's
>> > almost never marked as such.
>>
>> From the rndis_wlan kconfig:
>>
>>           "All of these devices are based on Broadcom 4320 chip which is the
>>           only wireless RNDIS chip known to date."
>
> Yeah, but it's more of a spec. Anyway I guess that doesn't matter much.

Oh ok, I didn't get that from the kconfig entry, we can fix that though.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 65397fe..1a8e9bd 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -378,6 +378,14 @@  config USB_ZD1201
 
 endif # ZYDAS_80211
 
+menuconfig BROADCOM_80211
+	bool "Broadcom Wireless Cards"
+	depends on WLAN_80211
+	---help---
+	  This will enable the support for Broadcom wireless drivers. This
+	  includes b43 driver, b43legacy driver and the rndis_wlan driver.
+
+if BROADCOM_80211
 source "drivers/net/wireless/b43/Kconfig"
 source "drivers/net/wireless/b43legacy/Kconfig"
 
@@ -410,6 +418,8 @@  config USB_NET_RNDIS_WLAN
 
 	  If you choose to build a module, it'll be called rndis_wlan.
 
+endif # BROADCOM_80211
+
 menuconfig REALTEK_80211
 	bool "Realtek Wireless Cards"
 	depends on WLAN_80211