[v5,0/6] Move TXQ scheduling and airtime fairness into mac80211

Message ID	1545181331-5288-1-git-send-email-rmanohar@codeaurora.org (mailing list archive)
Headers	show Return-Path: <ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org> sender: rmanohar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1EB7C6098C; Wed, 19 Dec 2018 01:02:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1EB7C6098C From: Rajkumar Manoharan <rmanohar@codeaurora.org> To: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH v5 0/6] Move TXQ scheduling and airtime fairness into mac80211 Date: Tue, 18 Dec 2018 17:02:05 -0800 Message-Id: <1545181331-5288-1-git-send-email-rmanohar@codeaurora.org> MIME-Version: 1.0 Precedence: list Cc: make-wifi-fast@lists.bufferbloat.net, Rajkumar Manoharan <rmanohar@codeaurora.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" <ath10k-bounces@lists.infradead.org> Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org
Series	Move TXQ scheduling and airtime fairness into mac80211 \| expand [v5,0/6] Move TXQ scheduling and airtime fairness into mac80211 [v5,1/6] mac80211: Add TXQ scheduling API [v5,2/6] cfg80211: Add airtime statistics and settings [v5,3/6] mac80211: Add airtime accounting and scheduling to TXQs [v5,4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs [v5,5/6] ath10k: migrate to mac80211 txq scheduling [v5,6/6] ath10k: reporting estimated tx airtime for fairness

Message ID

1545181331-5288-1-git-send-email-rmanohar@codeaurora.org (mailing list archive)

Headers

DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1EB7C6098C
From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: [PATCH v5 0/6] Move TXQ scheduling and airtime fairness into mac80211
Date: Tue, 18 Dec 2018 17:02:05 -0800
Message-Id: <1545181331-5288-1-git-send-email-rmanohar@codeaurora.org>
MIME-Version: 1.0
Precedence: list
Cc: make-wifi-fast@lists.bufferbloat.net,
 Rajkumar Manoharan <rmanohar@codeaurora.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Sender: "ath10k" <ath10k-bounces@lists.infradead.org>
Errors-To: 
 ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org

Series

Move TXQ scheduling and airtime fairness into mac80211 | expand

Message

Rajkumar Manoharan Dec. 19, 2018, 1:02 a.m. UTC

All,

Sorry for the long delay. Here is the consolidated series of mac80211,
ath9k and ath10k changes for moving TXQ scheduling and airtime fairness
into mac80211 and support airtime fairness.

Three main APIs are defined for TXQ scheduling.
  - ieee80211_next_txq
  - ieee80211_return_txq
  - ieee80211_txq_may_transmit

and two APIs for synchronization when the driver wants to iterate
through all TXQs.
  - ieee80211_txq_schedule_start
  - ieee80211_txq_schedule_end

The earlier discussions:
https://patchwork.kernel.org/project/linux-wireless/list/?series=&submitter=&state=*&q=TXQ+scheduling&archive=both&delegate=

-Rajkumar

v2:
 - replaced driver specific airtime default by multiplier
 - fixed tab intent
 - fixed author and commit log
v3:
 - fixed checkpatch warnings and kbuild bot errors.
   few of over 80 char warnings are left.
v4:
 - Folded Louie's airtime counter reset change
 - rebased the series on top of mac80211 tree.
v5:
 - fix kbuild-robot errors (s/BIT/BIT_ULL)

Kan Yan (1):
  ath10k: reporting estimated tx airtime for fairness

Toke Høiland-Jørgensen (5):
  mac80211: Add TXQ scheduling API
  cfg80211: Add airtime statistics and settings
  mac80211: Add airtime accounting and scheduling to TXQs
  ath9k: Switch to mac80211 TXQ scheduling and airtime APIs
  ath10k: migrate to mac80211 txq scheduling

 drivers/net/wireless/ath/ath10k/core.c     |   2 -
 drivers/net/wireless/ath/ath10k/core.h     |   8 +-
 drivers/net/wireless/ath/ath10k/htc.h      |   1 -
 drivers/net/wireless/ath/ath10k/htt_rx.c   |   9 ++
 drivers/net/wireless/ath/ath10k/mac.c      | 155 +++++++++++-------
 drivers/net/wireless/ath/ath10k/txrx.c     |   4 +
 drivers/net/wireless/ath/ath9k/ath9k.h     |  14 --
 drivers/net/wireless/ath/ath9k/debug.c     |   3 -
 drivers/net/wireless/ath/ath9k/debug.h     |   8 -
 drivers/net/wireless/ath/ath9k/debug_sta.c |  70 ---------
 drivers/net/wireless/ath/ath9k/init.c      |   3 +-
 drivers/net/wireless/ath/ath9k/recv.c      |   9 +-
 drivers/net/wireless/ath/ath9k/xmit.c      | 244 +++++++++--------------------
 include/net/cfg80211.h                     |  10 +-
 include/net/mac80211.h                     | 121 +++++++++++++-
 include/uapi/linux/nl80211.h               |  15 ++
 net/mac80211/agg-tx.c                      |   2 +-
 net/mac80211/cfg.c                         |   3 +
 net/mac80211/debugfs.c                     |   3 +
 net/mac80211/debugfs_sta.c                 |  68 +++++++-
 net/mac80211/driver-ops.h                  |   9 ++
 net/mac80211/ieee80211_i.h                 |  11 ++
 net/mac80211/main.c                        |   9 ++
 net/mac80211/sta_info.c                    |  46 +++++-
 net/mac80211/sta_info.h                    |  13 ++
 net/mac80211/status.c                      |   6 +
 net/mac80211/tx.c                          | 140 ++++++++++++++++-
 net/wireless/nl80211.c                     |  30 ++++
 28 files changed, 662 insertions(+), 354 deletions(-)

Comments

Toke Høiland-Jørgensen Dec. 19, 2018, 1:12 p.m. UTC | #1

Rajkumar Manoharan <rmanohar@codeaurora.org> writes:

> All,
>
> Sorry for the long delay. Here is the consolidated series of mac80211,
> ath9k and ath10k changes for moving TXQ scheduling and airtime fairness
> into mac80211 and support airtime fairness.

Thanks for taking care of the respin!

Johannes, I think it's safe for you to review this version. I have
started working on another approach for the scheduler algorithm itself,
but it is fine to do as an incremental patch on top of this as it
shouldn't impact the API. Having a separate patch also makes testing
easier anyway. I'll see if I can't get it to a working state over the
holidays...

-Toke

Dave Taht Dec. 19, 2018, 1:34 p.m. UTC | #2

Toke Høiland-Jørgensen <toke@toke.dk> writes:

> Rajkumar Manoharan <rmanohar@codeaurora.org> writes:
>
>> All,
>>
>> Sorry for the long delay. Here is the consolidated series of mac80211,
>> ath9k and ath10k changes for moving TXQ scheduling and airtime fairness
>> into mac80211 and support airtime fairness.
>
> Thanks for taking care of the respin!
>
> Johannes, I think it's safe for you to review this version. I have
> started working on another approach for the scheduler algorithm itself,
> but it is fine to do as an incremental patch on top of this as it
> shouldn't impact the API. Having a separate patch also makes testing
> easier anyway. I'll see if I can't get it to a working state over the
> holidays...

There comes a time in all patch series where the best thing to do is
commit it, and inflict it on others. Now may be that time.

Acked-by: Dave Taht <dave.taht@gmail.com>

>
> -Toke
> _______________________________________________
> Make-wifi-fast mailing list
> Make-wifi-fast@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/make-wifi-fast