mbox series

[0/2] ath10k: Enable QDSS clock on sm8150

Message ID 20191223054855.3020665-1-bjorn.andersson@linaro.org (mailing list archive)
Headers show
Series ath10k: Enable QDSS clock on sm8150 | expand

Message

Bjorn Andersson Dec. 23, 2019, 5:48 a.m. UTC
On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system
will reset due to an NoC error. So this adds an optional clock to the ath10k
binding and makes sure it's enabled while the WiFi firmware needs it.

Bjorn Andersson (2):
  ath10k: Add optional qdss clk
  arm64: dts: qcom: sm8150: Specify qdss clock for wifi

 .../devicetree/bindings/net/wireless/qcom,ath10k.txt          | 2 +-
 arch/arm64/boot/dts/qcom/sm8150.dtsi                          | 4 ++--
 drivers/net/wireless/ath/ath10k/snoc.c                        | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Kalle Valo Jan. 10, 2020, 7:16 a.m. UTC | #1
Bjorn Andersson <bjorn.andersson@linaro.org> writes:

> On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system
> will reset due to an NoC error. So this adds an optional clock to the ath10k
> binding and makes sure it's enabled while the WiFi firmware needs it.
>
> Bjorn Andersson (2):
>   ath10k: Add optional qdss clk
>   arm64: dts: qcom: sm8150: Specify qdss clock for wifi
>
>  .../devicetree/bindings/net/wireless/qcom,ath10k.txt          | 2 +-
>  arch/arm64/boot/dts/qcom/sm8150.dtsi                          | 4 ++--
>  drivers/net/wireless/ath/ath10k/snoc.c                        | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

Via which tree are these supposed to go? I'll take patch 1 and arm
mantainers take patch 2, or what?
Kalle Valo Jan. 15, 2020, 9:04 a.m. UTC | #2
Kalle Valo <kvalo@codeaurora.org> writes:

> Bjorn Andersson <bjorn.andersson@linaro.org> writes:
>
>> On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system
>> will reset due to an NoC error. So this adds an optional clock to the ath10k
>> binding and makes sure it's enabled while the WiFi firmware needs it.
>>
>> Bjorn Andersson (2):
>>   ath10k: Add optional qdss clk
>>   arm64: dts: qcom: sm8150: Specify qdss clock for wifi
>>
>>  .../devicetree/bindings/net/wireless/qcom,ath10k.txt          | 2 +-
>>  arch/arm64/boot/dts/qcom/sm8150.dtsi                          | 4 ++--
>>  drivers/net/wireless/ath/ath10k/snoc.c                        | 2 +-
>>  3 files changed, 4 insertions(+), 4 deletions(-)
>
> Via which tree are these supposed to go? I'll take patch 1 and arm
> mantainers take patch 2, or what?

No reply, so I'm planning to take patch 1. Please holler if I
misunderstood.
Bjorn Andersson Jan. 15, 2020, 7:19 p.m. UTC | #3
On Wed 15 Jan 01:04 PST 2020, Kalle Valo wrote:

> Kalle Valo <kvalo@codeaurora.org> writes:
> 
> > Bjorn Andersson <bjorn.andersson@linaro.org> writes:
> >
> >> On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system
> >> will reset due to an NoC error. So this adds an optional clock to the ath10k
> >> binding and makes sure it's enabled while the WiFi firmware needs it.
> >>
> >> Bjorn Andersson (2):
> >>   ath10k: Add optional qdss clk
> >>   arm64: dts: qcom: sm8150: Specify qdss clock for wifi
> >>
> >>  .../devicetree/bindings/net/wireless/qcom,ath10k.txt          | 2 +-
> >>  arch/arm64/boot/dts/qcom/sm8150.dtsi                          | 4 ++--
> >>  drivers/net/wireless/ath/ath10k/snoc.c                        | 2 +-
> >>  3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > Via which tree are these supposed to go? I'll take patch 1 and arm
> > mantainers take patch 2, or what?

That sounds good (you take the ath10k and we'll take the dts).

> 
> No reply, so I'm planning to take patch 1. Please holler if I
> misunderstood.
> 

Sorry.

Regards,
Bjorn
Bjorn Andersson Jan. 27, 2020, 11:42 p.m. UTC | #4
On Mon 27 Jan 10:40 PST 2020, Stephen Boyd wrote:

> Quoting Bjorn Andersson (2019-12-22 21:48:53)
> > On SM8150 the WiFi firmware depends on the QDSS clock ticking, or the system
> > will reset due to an NoC error. So this adds an optional clock to the ath10k
> > binding and makes sure it's enabled while the WiFi firmware needs it.
> 
> Hopefully this isn't a requirement in production firmware? Seems
> wasteful to keep the debug clk enabled in the field when nobody is
> debugging anything.
> 

I'm confused about this as well, but I'm told that it was fixed
post-8150.

Regards,
Bjorn