mbox series

[00/14] Rid W=1 warnings in SPI

Message ID 20200715150632.409077-1-lee.jones@linaro.org (mailing list archive)
Headers show
Series Rid W=1 warnings in SPI | expand

Message

Lee Jones July 15, 2020, 3:06 p.m. UTC
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

After these patches are applied, the build system no longer
complains about any W=0 nor W=1 level warnings in drivers/spi.

Hurrah!

Lee Jones (14):
  spi: spi-loopback-test: Fix formatting issues in function header
    blocks
  spi: spi-bitbang: Demote obvious misuse of kerneldoc to standard
    comment blocks
  spi: spi-davinci: Fix a few kerneldoc misspellings and API slippages
  spi: spi-ep93xx: Fix API slippage
  spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct
    meson_spifc'
  spi: spi-meson-spicc: Remove set but never used variable 'data' from
    meson_spicc_reset_fifo()
  spi: spi-s3c64xx: Add missing entries for structs
    's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data'
  spi: spi-pl022: Provide missing struct attribute/function param docs
  spi: spi-zynq-qspi: Add description for 2 missing
    attributes/parameters
  spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc
  spi: spi-topcliff-pch: Add missing descriptions to 'struct
    pch_spi_data'
  spi: spi-at91-usart: Make use of the defined 'struct of_device_id'
  spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when
  spi: spi-amd: Do not define 'struct acpi_device_id' when

 drivers/spi/spi-amd.c           |  2 ++
 drivers/spi/spi-at91-usart.c    |  1 +
 drivers/spi/spi-bitbang.c       |  6 +++---
 drivers/spi/spi-davinci.c       |  7 ++++---
 drivers/spi/spi-ep93xx.c        |  2 +-
 drivers/spi/spi-loopback-test.c | 16 ++++++++--------
 drivers/spi/spi-meson-spicc.c   |  4 +---
 drivers/spi/spi-meson-spifc.c   |  2 +-
 drivers/spi/spi-pl022.c         | 14 ++++++++++----
 drivers/spi/spi-pxa2xx.c        |  2 ++
 drivers/spi/spi-s3c64xx.c       |  9 ++++++++-
 drivers/spi/spi-topcliff-pch.c  |  8 ++++++--
 drivers/spi/spi-zynq-qspi.c     |  3 ++-
 drivers/spi/spi-zynqmp-gqspi.c  |  6 +++---
 14 files changed, 52 insertions(+), 30 deletions(-)

Comments

Mark Brown July 20, 2020, 11:12 a.m. UTC | #1
On Wed, 15 Jul 2020 16:06:18 +0100, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> After these patches are applied, the build system no longer
> complains about any W=0 nor W=1 level warnings in drivers/spi.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[01/13] spi: spi-loopback-test: Fix formatting issues in function header blocks
        commit: 055fe5f499b6783a3eac4978c9012ff08934f37c
[02/13] spi: spi-bitbang: Demote obvious misuse of kerneldoc to standard comment blocks
        commit: c13b5044ab0a484dfe4a8a1d946f3da6abb8d245
[03/13] spi: spi-davinci: Fix a few kerneldoc misspellings and API slippages
        commit: f6305d2706a7f1427d237044c470057508836590
[04/13] spi: spi-ep93xx: Fix API slippage
        commit: dfa51f6db34608d7829a5ef6add11557e548969a
[05/13] spi: spi-meson-spifc: Fix misdocumenting of 'dev' in 'struct meson_spifc'
        commit: 78a7f0c0a170ddef39822b8ec2b6311f0f27ea9b
[06/13] spi: spi-meson-spicc: Remove set but never used variable 'data' from meson_spicc_reset_fifo()
        commit: d9b883aeaeb05d196244383ebe1bc52e39697948
[07/13] spi: spi-s3c64xx: Add missing entries for structs 's3c64xx_spi_dma_data' and 's3c64xx_spi_dma_data'
        commit: 6b8d1e4739f41fcfb5d9adfd91b0ddfd1487c7e5
[08/13] spi: spi-pl022: Provide missing struct attribute/function param docs
        commit: c7cd1dfbd8bbd4a61a39773537db541e247a7ab0
[09/13] spi: spi-zynq-qspi: Add description for 2 missing attributes/parameters
        commit: e867feecda9bbbf854a5e6d8c5d765e31ebc545b
[10/13] spi: spi-zynqmp-gqspi: Correct a couple of misspellings in kerneldoc
        commit: 4b42b0b498124e4d38eaccbbb6b79e2a0ad1e047
[11/13] spi: spi-topcliff-pch: Add missing descriptions to 'struct pch_spi_data'
        commit: decf5326944bc6c32c9256f3992adfb7283cb0f3
[12/13] spi: spi-pxa2xx: Do not define 'struct acpi_device_id' when !CONFIG_ACPI
        commit: 9b2d611929afefee78037c92919d633aae35636a
[13/13] spi: spi-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI
        commit: 85ed0f63c0e362afc51e541a8216a58094c36f6b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark