| Message ID | 1507974371-7419-1-git-send-email-chris.gekas@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9d414949a3061ba1a76fbc7900e00902968df4ef |
| Delegated to: | Kalle Valo |
| Headers | show |
Christos Gkekas <chris.gekas@gmail.com> wrote: > Variable val is unsigned, so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 9d414949a306 ath9k: debug: Remove redundant check
diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c index 01fa301..4f5f141 100644 --- a/drivers/net/wireless/ath/ath9k/debug.c +++ b/drivers/net/wireless/ath/ath9k/debug.c @@ -1167,7 +1167,7 @@ static ssize_t write_file_tpc(struct file *file, const char __user *user_buf, if (kstrtoul(buf, 0, &val)) return -EINVAL; - if (val < 0 || val > 1) + if (val > 1) return -EINVAL; tpc_enabled = !!val;
Variable val is unsigned, so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> --- drivers/net/wireless/ath/ath9k/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)