diff mbox

✗ Fi.CI.BAT: failure for drm/i915: Unifying debugfs return codes for unsupported features

Message ID op.zae9yzkwxaggs7@mwajdecz-mobl1.ger.corp.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Michal Wajdeczko Nov. 28, 2017, 4:41 p.m. UTC 
On Tue, 28 Nov 2017 17:07:27 +0100, Patchwork  
<patchwork@emeril.freedesktop.org> wrote:

> == Series Details ==
>
> Series: drm/i915: Unifying debugfs return codes for unsupported features
> URL   : https://patchwork.freedesktop.org/series/34552/
> State : failure
>
> == Summary ==
>
> Series 34552v1 drm/i915: Unifying debugfs return codes for unsupported  
> features
> https://patchwork.freedesktop.org/api/1.0/series/34552/revisions/1/mbox/
>
> Test kms_frontbuffer_tracking:
>         Subgroup basic:
>                 skip       -> FAIL       (fi-elk-e7500)
>                 pass       -> FAIL       (fi-byt-j1900)
>                 pass       -> FAIL       (fi-byt-n2820)
>                 pass       -> FAIL       (fi-bsw-n3050)
>

It looks that "igt/kms_frontbuffer_tracking: Keep the debugfs dir around"
introduced igt_assert that fires when we try to return -ENODEV.

I think we can replace it with proper handling (see __igt_debugfs_read)
diff mbox

Patch

diff --git a/tests/kms_frontbuffer_tracking.c  
b/tests/kms_frontbuffer_tracking.c
index a068c8a..50019d1 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -783,7 +783,8 @@  static bool set_mode_for_params(struct modeset_params  
*params)
  static void __debugfs_read(const char *param, char *buf, int len)
  {
         len = igt_sysfs_read(drm.debugfs, param, buf, len - 1);
-       igt_assert(len > 0);
+       if (len < 0)
+               len = 0;
         buf[len] = '\0';
  }