diff mbox

brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

Message ID 1512639183-3357-1-git-send-email-wright.feng@cypress.com (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show

Commit Message

Wright Feng Dec. 7, 2017, 9:33 a.m. UTC 
From: Double Lo <double.lo@cypress.com>

This patch will add 43455 into the save-restore(SR) capable chip list, so
the SR engine will be enabled with 43455 FW which built-in the -sr
function.

Signed-off-by: Double Lo <double.lo@cypress.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kalle Valo Dec. 14, 2017, 12:39 p.m. UTC | #1 
Wright Feng <wright.feng@cypress.com> wrote:

> From: Double Lo <double.lo@cypress.com>
> 
> This patch will add 43455 into the save-restore(SR) capable chip list, so
> the SR engine will be enabled with 43455 FW which built-in the -sr
> function.
> 
> Signed-off-by: Double Lo <double.lo@cypress.com>

Wright's s-o-b is missing:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing
Wright Feng Dec. 18, 2017, 2:03 a.m. UTC | #2 
On 2017/12/14 下午 08:39, Kalle Valo wrote:
> Wright Feng <wright.feng@cypress.com> wrote:
> 
>> From: Double Lo <double.lo@cypress.com>
>>
>> This patch will add 43455 into the save-restore(SR) capable chip list, so
>> the SR engine will be enabled with 43455 FW which built-in the -sr
>> function.
>>
>> Signed-off-by: Double Lo <double.lo@cypress.com>
Signed-off-by: Wright Feng <wright.feng@cypress.com>
> 
> Wright's s-o-b is missing:
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing
> 
Kalle,
Thanks for reminding, please let me know if I have to send [Patch v2] 
for this.
Kalle Valo Dec. 18, 2017, 1:39 p.m. UTC | #3 
Wright Feng <wright.feng@cypress.com> writes:

> On 2017/12/14 下午 08:39, Kalle Valo wrote:
>> Wright Feng <wright.feng@cypress.com> wrote:
>>
>>> From: Double Lo <double.lo@cypress.com>
>>>
>>> This patch will add 43455 into the save-restore(SR) capable chip list, so
>>> the SR engine will be enabled with 43455 FW which built-in the -sr
>>> function.
>>>
>>> Signed-off-by: Double Lo <double.lo@cypress.com>
> Signed-off-by: Wright Feng <wright.feng@cypress.com>
>>
>> Wright's s-o-b is missing:
>>
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing
>>
> Kalle,
> Thanks for reminding, please let me know if I have to send [Patch v2]
> for this.

Yes, please send v2.

To save my time you can actually check this from patchwork:

https://patchwork.kernel.org/patch/10097897/

If the state is "Changes Requested" it means that I'm expecting the
author to submit a new version. More info:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork
diff mbox

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
index c5d1a1c..f7b30ce 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
@@ -1338,6 +1338,7 @@  bool brcmf_chip_sr_capable(struct brcmf_chip *pub)
 	switch (pub->chip) {
 	case BRCM_CC_4354_CHIP_ID:
 	case BRCM_CC_4356_CHIP_ID:
+	case BRCM_CC_4345_CHIP_ID:
 		/* explicitly check SR engine enable bit */
 		pmu_cc3_mask = BIT(2);
 		/* fall-through */