| Message ID | 20180112115209.17437-1-leon@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Leon Romanovsky |
| Headers | show |
On Fri, Jan 12, 2018 at 01:52:09PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@mellanox.com> > > Add Fedora 27 to the list of cbuild targets. > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > buildlib/cbuild | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/buildlib/cbuild b/buildlib/cbuild > index 3f659bf8..0ef80b60 100755 > +++ b/buildlib/cbuild > @@ -141,6 +141,20 @@ class fc26(Environment): > " ".join(sorted(self.pkgs)))); > return res; > > +class fc27(Environment): > + docker_parent = "fedora:27"; > + pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"}; > + name = "fc27"; > + specfile = "redhat/rdma-core.spec"; > + ninja_cmd = "ninja-build"; > + is_rpm = True; > + > + def get_docker_file(self): > + res = DockerFile(self.docker_parent); > + res.lines.append("RUN dnf install -y %s && dnf clean all"%( > + " ".join(sorted(self.pkgs)))); > + return res; > + > # ------------------------------------------------------------------------- > > class APTEnvironment(Environment): > @@ -337,6 +351,7 @@ environments = [centos6(), > jessie(), > stretch(), > fc26(), > + fc27(), I've been keeping only 1 fc container, no need to test old fedora. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 12, 2018 at 11:08:55AM -0700, Jason Gunthorpe wrote: > On Fri, Jan 12, 2018 at 01:52:09PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@mellanox.com> > > > > Add Fedora 27 to the list of cbuild targets. > > > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > > buildlib/cbuild | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/buildlib/cbuild b/buildlib/cbuild > > index 3f659bf8..0ef80b60 100755 > > +++ b/buildlib/cbuild > > @@ -141,6 +141,20 @@ class fc26(Environment): > > " ".join(sorted(self.pkgs)))); > > return res; > > > > +class fc27(Environment): > > + docker_parent = "fedora:27"; > > + pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"}; > > + name = "fc27"; > > + specfile = "redhat/rdma-core.spec"; > > + ninja_cmd = "ninja-build"; > > + is_rpm = True; > > + > > + def get_docker_file(self): > > + res = DockerFile(self.docker_parent); > > + res.lines.append("RUN dnf install -y %s && dnf clean all"%( > > + " ".join(sorted(self.pkgs)))); > > + return res; > > + > > # ------------------------------------------------------------------------- > > > > class APTEnvironment(Environment): > > @@ -337,6 +351,7 @@ environments = [centos6(), > > jessie(), > > stretch(), > > fc26(), > > + fc27(), > > I've been keeping only 1 fc container, no need to test old fedora. I'll remove the rest. > > Jason
On Fri, 2018-01-12 at 13:52 +0200, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@mellanox.com> > > Add Fedora 27 to the list of cbuild targets. > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > --- > buildlib/cbuild | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/buildlib/cbuild b/buildlib/cbuild > index 3f659bf8..0ef80b60 100755 > --- a/buildlib/cbuild > +++ b/buildlib/cbuild > @@ -141,6 +141,20 @@ class fc26(Environment): > " ".join(sorted(self.pkgs)))); > return res; > > +class fc27(Environment): > + docker_parent = "fedora:27"; > + pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"}; Is there some reason why are you pulling a fedora:27 container and then centos packages?
On Wed, Jan 17, 2018 at 10:14:37AM -0500, Doug Ledford wrote: > On Fri, 2018-01-12 at 13:52 +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@mellanox.com> > > > > Add Fedora 27 to the list of cbuild targets. > > > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > > buildlib/cbuild | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/buildlib/cbuild b/buildlib/cbuild > > index 3f659bf8..0ef80b60 100755 > > +++ b/buildlib/cbuild > > @@ -141,6 +141,20 @@ class fc26(Environment): > > " ".join(sorted(self.pkgs)))); > > return res; > > > > +class fc27(Environment): > > + docker_parent = "fedora:27"; > > + pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"}; > > Is there some reason why are you pulling a fedora:27 container and then > centos packages? That is the pattern, centos7 has a list of required packages that is most similar to fc27. It will make more sense when the patch is respun to have fc27 replace fc26.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 17, 2018 at 09:16:14AM -0700, Jason Gunthorpe wrote: > On Wed, Jan 17, 2018 at 10:14:37AM -0500, Doug Ledford wrote: > > On Fri, 2018-01-12 at 13:52 +0200, Leon Romanovsky wrote: > > > From: Leon Romanovsky <leonro@mellanox.com> > > > > > > Add Fedora 27 to the list of cbuild targets. > > > > > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > > > buildlib/cbuild | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > diff --git a/buildlib/cbuild b/buildlib/cbuild > > > index 3f659bf8..0ef80b60 100755 > > > +++ b/buildlib/cbuild > > > @@ -141,6 +141,20 @@ class fc26(Environment): > > > " ".join(sorted(self.pkgs)))); > > > return res; > > > > > > +class fc27(Environment): > > > + docker_parent = "fedora:27"; > > > + pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"}; > > > > Is there some reason why are you pulling a fedora:27 container and then > > centos packages? > > That is the pattern, centos7 has a list of required packages that is > most similar to fc27. It will make more sense when the patch is respun > to have fc27 replace fc26.. I'll do. Thanks > > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/buildlib/cbuild b/buildlib/cbuild index 3f659bf8..0ef80b60 100755 --- a/buildlib/cbuild +++ b/buildlib/cbuild @@ -141,6 +141,20 @@ class fc26(Environment): " ".join(sorted(self.pkgs)))); return res; +class fc27(Environment): + docker_parent = "fedora:27"; + pkgs = (centos7.pkgs - {"make"}) | {"ninja-build"}; + name = "fc27"; + specfile = "redhat/rdma-core.spec"; + ninja_cmd = "ninja-build"; + is_rpm = True; + + def get_docker_file(self): + res = DockerFile(self.docker_parent); + res.lines.append("RUN dnf install -y %s && dnf clean all"%( + " ".join(sorted(self.pkgs)))); + return res; + # ------------------------------------------------------------------------- class APTEnvironment(Environment): @@ -337,6 +351,7 @@ environments = [centos6(), jessie(), stretch(), fc26(), + fc27(), leap(), tumbleweed(), debian_experimental(),