diff mbox

ath10k: remove redundant -ve check against u32 integer size

Message ID 20180112172713.28252-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit 95f27a51ee02fdd9e7afc06f090c7171673a79ac
Delegated to: Kalle Valo
Headers show

Commit Message

Colin King Jan. 12, 2018, 5:27 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Variable section_table.size is a u32 and so cannot be less than
zero, hence the less than zero check is redundant and can be
removed.

Detected by CoverityScan, CID#1463855 ("Unsigned compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/ath/ath10k/pci.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Kalle Valo Jan. 16, 2018, 2:34 p.m. UTC | #1 
Colin Ian King <colin.king@canonical.com> wrote:

> Variable section_table.size is a u32 and so cannot be less than
> zero, hence the less than zero check is redundant and can be
> removed.
> 
> Detected by CoverityScan, CID#1463855 ("Unsigned compared against 0")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

95f27a51ee02 ath10k: remove redundant -ve check against u32 integer size
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index f6a23f2d0335..355db6a0fcf3 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1478,9 +1478,6 @@  static int ath10k_pci_dump_memory_section(struct ath10k *ar,
 	if (!mem_region || !buf)
 		return 0;
 
-	if (mem_region->section_table.size < 0)
-		return 0;
-
 	cur_section = &mem_region->section_table.sections[0];
 
 	if (mem_region->start > cur_section->start) {