Message ID | 20180313124932.15038-1-hariprasath.elango@gmail.com (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Kalle Valo |
Headers | show |
On Tue, Mar 13, 2018 at 06:19:32PM +0530, hariprasath.elango@gmail.com wrote: > From: HariPrasath Elango <hariprasath.elango@gmail.com> > > kmalloc followed by memcpy can be replaced by kmemdup.Also added the > related error handling part > > Signed-off-by: HariPrasath Elango <hariprasath.elango@gmail.com> > --- > drivers/staging/wilc1000/host_interface.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) You have sent at least 8 patches for this driver over the past day, yet I have no idea what order to apply these in at all. Please resend them all as a proper patch series, numbered so I have a clue as to what order to apply them in. Also preserve the acks/reviews that others have provided so they don't have to provide that again. thanks, greg k-h
On Wed, Mar 14, 2018 at 12:38:18PM +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 13, 2018 at 06:19:32PM +0530, hariprasath.elango@gmail.com wrote: > > From: HariPrasath Elango <hariprasath.elango@gmail.com> > > > > kmalloc followed by memcpy can be replaced by kmemdup.Also added the > > related error handling part > > > > Signed-off-by: HariPrasath Elango <hariprasath.elango@gmail.com> > > --- > > drivers/staging/wilc1000/host_interface.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > You have sent at least 8 patches for this driver over the past day, yet > I have no idea what order to apply these in at all. > > Please resend them all as a proper patch series, numbered so I have a > clue as to what order to apply them in. Also preserve the acks/reviews > that others have provided so they don't have to provide that again. > > thanks, > > greg k-h Hi Greg, thanks. Yes I will send a patchset to make things easier for you keeping in tact the review history regards, hari prasath
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 0fac8e1..4ae2da6 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -992,9 +992,13 @@ static s32 handle_connect(struct wilc_vif *vif, if (memcmp("DIRECT-", pstrHostIFconnectAttr->ssid, 7)) { info_element_size = hif_drv->usr_conn_req.ies_len; - info_element = kmalloc(info_element_size, GFP_KERNEL); - memcpy(info_element, hif_drv->usr_conn_req.ies, - info_element_size); + info_element = kmemdup(hif_drv->usr_conn_req.ies, + info_element_size, + GFP_KERNEL); + if (!info_element) { + result = -ENOMEM; + goto ERRORHANDLER; + } } wid_list[wid_cnt].id = (u16)WID_11I_MODE;