| Message ID | 20180405154949.GA32223@embeddedor.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3763770044640caeb1101cdea40697cc0814403c |
| Delegated to: | Kalle Valo |
| Headers | show |
Hello Gustavo, > In case memory resources for fw were succesfully allocated, release > them before jumping to fw_load_fail. > > Addresses-Coverity-ID: 1466092 ("Resource leak") > Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 4 ++++ > 1 file changed, 4 insertions(+) Thanks for the patch! Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> Regards, Sergey
Hi Sergey, On 04/05/2018 11:31 AM, Sergey Matyukevich wrote: > Hello Gustavo, > >> In case memory resources for fw were succesfully allocated, release >> them before jumping to fw_load_fail. >> >> Addresses-Coverity-ID: 1466092 ("Resource leak") >> Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 4 ++++ >> 1 file changed, 4 insertions(+) > > Thanks for the patch! > Glad to help. :) > Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> > Thanks -- Gustavo
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote: > In case memory resources for fw were succesfully allocated, release > them before jumping to fw_load_fail. > > Addresses-Coverity-ID: 1466092 ("Resource leak") > Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> Patch applied to wireless-drivers-next.git, thanks. 376377004464 qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler
diff --git a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c index f117904..6c1e139 100644 --- a/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c +++ b/drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c @@ -1185,6 +1185,10 @@ static void qtnf_fw_work_handler(struct work_struct *work) if (qtnf_poll_state(&priv->bda->bda_ep_state, QTN_EP_FW_LOADRDY, QTN_FW_DL_TIMEOUT_MS)) { pr_err("card is not ready\n"); + + if (!flashboot) + release_firmware(fw); + goto fw_load_fail; }
In case memory resources for fw were succesfully allocated, release them before jumping to fw_load_fail. Addresses-Coverity-ID: 1466092 ("Resource leak") Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 4 ++++ 1 file changed, 4 insertions(+)