[Bug,107384] random tab crashes in firefox nightly
diff mbox series

Message ID bug-107384-502-WkPQWjcTeh@http.bugs.freedesktop.org/
State New
Headers show
Series
  • [Bug,107384] random tab crashes in firefox nightly
Related show

Commit Message

bugzilla-daemon@freedesktop.org July 28, 2018, 11:16 p.m. UTC
https://bugs.freedesktop.org/show_bug.cgi?id=107384

--- Comment #7 from Christoph Haag <haagch@frickel.club> ---
(In reply to Chris Wilson from comment #5)
> Sigh.
> 
> diff --git a/src/loader/loader.c b/src/loader/loader.c
> index 43275484cc..87b7281f78 100644
> --- a/src/loader/loader.c
> +++ b/src/loader/loader.c
> @@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(int default_fd, bool
> *different_device)
>  static int
>  drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id)
>  {
> -   drmDevicePtr device;
> +   drmDevicePtr device = NULL;
>     int ret;
>  
>     if (drmGetDevice2(fd, 0, &device) == 0) {

Thanks, looks like this is my issue too.

    if (drmGetDevice2(fd, 0, &device) != 0)
@@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(int default_fd, bool
*different_device)
 static int
 drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id)
 {
-   drmDevicePtr device;
+   drmDevicePtr device = NULL;
    int ret;

    if (drmGetDevice2(fd, 0, &device) == 0) {

Patch
diff mbox series

diff --git a/src/loader/loader.c b/src/loader/loader.c
index 43275484cc2..02a1f97684f 100644
--- a/src/loader/loader.c
+++ b/src/loader/loader.c
@@ -167,7 +167,7 @@  static bool drm_device_matches_tag(drmDevicePtr device,
const char *prime_tag)

 static char *drm_get_id_path_tag_for_fd(int fd)
 {
-   drmDevicePtr device;
+   drmDevicePtr device = NULL;
    char *tag;