[2/2] arm64: dts: renesas: v3msk: add eMMC support
diff mbox series

Message ID 9da672a2-0269-4860-8912-189414b43d4c@cogentembedded.com
State Accepted
Commit 8d9923b3a2f6c0e4ad3f9d9cad6e9010cf0d67e6
Headers show
Series
  • Add R8A77980/Condor eMMC support
Related show

Commit Message

Sergei Shtylyov Aug. 21, 2018, 7:50 p.m. UTC
Add the eMMC chip support for the V3M Started Kit board.

Based on the original (and large) patches by Vladimir Barinov.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts |   26 +++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Simon Horman Aug. 22, 2018, 11:31 a.m. UTC | #1
On Tue, Aug 21, 2018 at 10:50:31PM +0300, Sergei Shtylyov wrote:
> Add the eMMC chip support for the V3M Started Kit board.
> 
> Based on the original (and large) patches by Vladimir Barinov.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

I am, however, curious to know about HS200.
Is it supported on the v3msk? If so, do you have any plans to enable it?
Sergei Shtylyov Aug. 22, 2018, 2:43 p.m. UTC | #2
On 08/22/2018 02:31 PM, Simon Horman wrote:

>> Add the eMMC chip support for the V3M Started Kit board.
>>
>> Based on the original (and large) patches by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
> 
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> 
> I am, however, curious to know about HS200.
> Is it supported on the v3msk? If so, do you have any plans to enable it?

   As I've already said, the eMMC chip only receives 3.3V on all its voltage inputs.

MBR, Sergei
Simon Horman Aug. 24, 2018, 8:24 a.m. UTC | #3
On Wed, Aug 22, 2018 at 05:43:11PM +0300, Sergei Shtylyov wrote:
> On 08/22/2018 02:31 PM, Simon Horman wrote:
> 
> >> Add the eMMC chip support for the V3M Started Kit board.
> >>
> >> Based on the original (and large) patches by Vladimir Barinov.
> >>
> >> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > 
> > Thanks,
> > 
> > This looks fine to me but I will wait to see if there are other reviews
> > before applying.
> > 
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> > 
> > I am, however, curious to know about HS200.
> > Is it supported on the v3msk? If so, do you have any plans to enable it?
> 
>    As I've already said, the eMMC chip only receives 3.3V on all its voltage inputs.

Thanks Sergei, got it.

I have applied this for v4.20.

Patch
diff mbox series

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts
@@ -51,6 +51,15 @@ 
 		regulator-always-on;
 	};
 
+	vcc_vddq_vin0: regulator-2 {
+		compatible = "regulator-fixed";
+		regulator-name = "VCC_VDDQ_VIN0";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
 	lvds-decoder {
 		compatible = "thine,thc63lvd1024";
 		vcc-supply = <&vcc_d3_3v>;
@@ -128,6 +137,12 @@ 
 		function = "i2c0";
 	};
 
+	mmc_pins: mmc_3_3v {
+		groups = "mmc_data8", "mmc_ctrl";
+		function = "mmc";
+		power-source = <3300>;
+	};
+
 	scif0_pins: scif0 {
 		groups = "scif0_data";
 		function = "scif0";
@@ -192,6 +207,17 @@ 
 	};
 };
 
+&mmc0 {
+	pinctrl-0 = <&mmc_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&vcc_d3_3v>;
+	vqmmc-supply = <&vcc_vddq_vin0>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
 &scif0 {
 	pinctrl-0 = <&scif0_pins>;
 	pinctrl-names = "default";