| Message ID | 20181106020402.21120-1-acelan.kao@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | [1/2] pci: prevent sk hynix nvme from entering D3 | expand |
On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote: > It leads to the power consumption raises to 2.2W during s2idle, while > it consumes less than 1W during long idle if put SK hynix nvme to D3 > and then enter s2idle. > >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its own > APST feature to do the power management. > To leverage its APST feature during s2idle, we can't disable nvme > device while suspending, too. > > BTW, prevent it from entering D3 will increase the power consumtion around > 0.13W ~ 0.15W during short/long idle, and the power consumption during > s2idle becomes 0.77W. Please get this fixed in firmware. And yes, depending on which Windows driver you use Windows might be doing very agressive runtime D3, which is parted of Windows modern standby, so it'll trip up there eventually as well.
Christoph Hellwig <hch@infradead.org> 於 2018年11月6日 週二 下午3:10寫道： > > On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote: > > It leads to the power consumption raises to 2.2W during s2idle, while > > it consumes less than 1W during long idle if put SK hynix nvme to D3 > > and then enter s2idle. > > >From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its own > > APST feature to do the power management. > > To leverage its APST feature during s2idle, we can't disable nvme > > device while suspending, too. > > > > BTW, prevent it from entering D3 will increase the power consumtion around > > 0.13W ~ 0.15W during short/long idle, and the power consumption during > > s2idle becomes 0.77W. > > Please get this fixed in firmware. And yes, depending on which Windows > driver you use Windows might be doing very agressive runtime D3, which > is parted of Windows modern standby, so it'll trip up there eventually > as well. Agree, this is not a good fix for Sk hynix nvme, so Dell is still pushing Sk hynix to fix it from firmware. But before the firmware is ready, this is still a issue that need to be fixed in kernel side, and the new firmware may not be applied on the old nvme modules. This list won't keep growing, and we'll keep an eye on the new firmware and co-work with engineers from Sky hynix to make sure this issue won't happen again.
On Tue, Nov 06, 2018 at 06:11:31PM +0800, AceLan Kao wrote: > Agree, this is not a good fix for Sk hynix nvme, so Dell is still pushing > Sk hynix to fix it from firmware. > But before the firmware is ready, this is still a issue that need to be fixed in > kernel side, and the new firmware may not be applied on the old nvme > modules. > This list won't keep growing, and we'll keep an eye on the new firmware and > co-work with engineers from Sky hynix to make sure this issue won't happen > again. We generally quirk for grave issues that make devices unusable. To me working around a D3 mode that consumers more power than D0 does not quite fit that bill.
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 4700d24e5d55..b7e6492e8311 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -1332,6 +1332,7 @@ DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_AL, PCI_ANY_ID, occur when mode detecting */ DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_VIA, PCI_ANY_ID, PCI_CLASS_STORAGE_IDE, 8, quirk_no_ata_d3); +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SK_HYNIX, 0x1527, quirk_no_ata_d3); /* * This was originally an Alpha-specific thing, but it really fits here. diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 69f0abe1ba1a..5f5adda07de0 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -3090,4 +3090,6 @@ #define PCI_VENDOR_ID_NCUBE 0x10ff +#define PCI_VENDOR_ID_SK_HYNIX 0x1c5c + #endif /* _LINUX_PCI_IDS_H */
It leads to the power consumption raises to 2.2W during s2idle, while it consumes less than 1W during long idle if put SK hynix nvme to D3 and then enter s2idle. From SK hynix FE, MS Windows doesn't put nvme to D3, and uses its own APST feature to do the power management. To leverage its APST feature during s2idle, we can't disable nvme device while suspending, too. BTW, prevent it from entering D3 will increase the power consumtion around 0.13W ~ 0.15W during short/long idle, and the power consumption during s2idle becomes 0.77W. Signed-off-by: AceLan Kao <acelan.kao@canonical.com> --- drivers/pci/quirks.c | 1 + include/linux/pci_ids.h | 2 ++ 2 files changed, 3 insertions(+)