| Message ID | 20181203180613.228133-8-james.morse@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | APEI in_nmi() rework and SDEI wire-up | expand |
On Mon, Dec 03, 2018 at 06:05:55PM +0000, James Morse wrote: > ghes_notify_nmi() checks ghes->flags for GHES_TO_CLEAR before going > on to __process_error(). This is pointless as ghes_read_estatus() > will always set this flag if it returns success, which was checked > earlier in the loop. Remove it. > > Signed-off-by: James Morse <james.morse@arm.com> > --- > drivers/acpi/apei/ghes.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index acf0c37e9af9..f7a0ff1c785a 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -936,9 +936,6 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs) > __ghes_panic(ghes); > } > > - if (!(ghes->flags & GHES_TO_CLEAR)) > - continue; > - > __process_error(ghes); > ghes_clear_estatus(ghes, buf_paddr); > } > -- Reviewed-by: Borislav Petkov <bp@suse.de>
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index acf0c37e9af9..f7a0ff1c785a 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -936,9 +936,6 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs) __ghes_panic(ghes); } - if (!(ghes->flags & GHES_TO_CLEAR)) - continue; - __process_error(ghes); ghes_clear_estatus(ghes, buf_paddr); }
ghes_notify_nmi() checks ghes->flags for GHES_TO_CLEAR before going on to __process_error(). This is pointless as ghes_read_estatus() will always set this flag if it returns success, which was checked earlier in the loop. Remove it. Signed-off-by: James Morse <james.morse@arm.com> --- drivers/acpi/apei/ghes.c | 3 --- 1 file changed, 3 deletions(-)