| Message ID | 2818b15332ab562722dfc324cf977b7eb4a04401.1545915059.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: drmP.h include removal w/ drm prep work | expand |
On Thu, Dec 27, 2018 at 02:56:38PM +0200, Jani Nikula wrote: > Make it easier to drop drmP.h includes. > > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > include/drm/drm_file.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h > index 84ac79219e4c..6710b612e2f6 100644 > --- a/include/drm/drm_file.h > +++ b/include/drm/drm_file.h > @@ -32,6 +32,7 @@ > > #include <linux/types.h> > #include <linux/completion.h> > +#include <linux/idr.h> Yup, we embed the struct idr. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > #include <uapi/drm/drm.h> > > -- > 2.11.0 >
Hi Jani, Thank you for the patch. On Thursday, 27 December 2018 14:56:38 EET Jani Nikula wrote: > Make it easier to drop drmP.h includes. How about explaining why idr.h is needed ? "drm_file.h embeds idr structures in DRM-specific structures. Include the corresponding header to make drm_file.h self-contained." Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > include/drm/drm_file.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h > index 84ac79219e4c..6710b612e2f6 100644 > --- a/include/drm/drm_file.h > +++ b/include/drm/drm_file.h > @@ -32,6 +32,7 @@ > > #include <linux/types.h> > #include <linux/completion.h> > +#include <linux/idr.h> > > #include <uapi/drm/drm.h>
diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index 84ac79219e4c..6710b612e2f6 100644 --- a/include/drm/drm_file.h +++ b/include/drm/drm_file.h @@ -32,6 +32,7 @@ #include <linux/types.h> #include <linux/completion.h> +#include <linux/idr.h> #include <uapi/drm/drm.h>
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- include/drm/drm_file.h | 1 + 1 file changed, 1 insertion(+)