diff mbox series

mt7601u: do not use WARN_ON in the datapath

Message ID ea874df744d188833cf8c38261b509ef246f3d5d.1548171270.git.lorenzo.bianconi@redhat.com (mailing list archive)
State Accepted
Commit b6958ad021c1f46675aa6d3602ce0d241a45785d
Delegated to: Kalle Valo
Headers show
Series mt7601u: do not use WARN_ON in the datapath | expand

Commit Message

Lorenzo Bianconi Jan. 22, 2019, 3:39 p.m. UTC
Substitute WARN_ON with WARN_ON_ONCE in mt7601u_rx_next_seg_len
routine

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
 drivers/net/wireless/mediatek/mt7601u/dma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jakub Kicinski Jan. 22, 2019, 7:30 p.m. UTC | #1
On Tue, 22 Jan 2019 16:39:34 +0100, Lorenzo Bianconi wrote:
> Substitute WARN_ON with WARN_ON_ONCE in mt7601u_rx_next_seg_len
> routine
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>

Acked-by: Jakub Kicinski <kubakici@wp.pl>
Kalle Valo Feb. 1, 2019, 12:41 p.m. UTC | #2
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:

> Substitute WARN_ON with WARN_ON_ONCE in mt7601u_rx_next_seg_len
> routine
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Acked-by: Jakub Kicinski <kubakici@wp.pl>

Patch applied to wireless-drivers-next.git, thanks.

b6958ad021c1 mt7601u: do not use WARN_ON in the datapath
diff mbox series

Patch

diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c
index 7f3e3983b781..f7edeffb2b19 100644
--- a/drivers/net/wireless/mediatek/mt7601u/dma.c
+++ b/drivers/net/wireless/mediatek/mt7601u/dma.c
@@ -124,9 +124,9 @@  static u16 mt7601u_rx_next_seg_len(u8 *data, u32 data_len)
 	u16 dma_len = get_unaligned_le16(data);
 
 	if (data_len < min_seg_len ||
-	    WARN_ON(!dma_len) ||
-	    WARN_ON(dma_len + MT_DMA_HDRS > data_len) ||
-	    WARN_ON(dma_len & 0x3))
+	    WARN_ON_ONCE(!dma_len) ||
+	    WARN_ON_ONCE(dma_len + MT_DMA_HDRS > data_len) ||
+	    WARN_ON_ONCE(dma_len & 0x3))
 		return 0;
 
 	return MT_DMA_HDRS + dma_len;