[06/17] ARM: dts: exynos: Add high speed I2C ports for exynos5260
diff mbox series

Message ID 20190128230700.7325-7-stuart.menefy@mathembedded.com
State Under Review
Headers show
Series
  • Resuscitate Exynos 5260 support
Related show

Commit Message

Stuart Menefy Jan. 28, 2019, 11:06 p.m. UTC
Add the missing high speed I2C ports.

Signed-off-by: Stuart Menefy <stuart.menefy@mathembedded.com>
---
 arch/arm/boot/dts/exynos5260.dtsi | 57 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

Comments

Krzysztof Kozlowski Jan. 29, 2019, 3:22 p.m. UTC | #1
Hi,

Thanks for patch, few comments below:

On Tue, 29 Jan 2019 at 00:08, Stuart Menefy
<stuart.menefy@mathembedded.com> wrote:
>
> Add the missing high speed I2C ports.
>
> Signed-off-by: Stuart Menefy <stuart.menefy@mathembedded.com>
> ---
>  arch/arm/boot/dts/exynos5260.dtsi | 57 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5260.dtsi b/arch/arm/boot/dts/exynos5260.dtsi
> index 14b423de9137..5f75ff422043 100644
> --- a/arch/arm/boot/dts/exynos5260.dtsi
> +++ b/arch/arm/boot/dts/exynos5260.dtsi
> @@ -17,6 +17,10 @@
>         #size-cells = <1>;
>
>         aliases {
> +               i2c0 = &hsi2c_0;
> +               i2c1 = &hsi2c_1;
> +               i2c2 = &hsi2c_2;
> +               i2c3 = &hsi2c_3;
>                 pinctrl0 = &pinctrl_0;
>                 pinctrl1 = &pinctrl_1;
>                 pinctrl2 = &pinctrl_2;
> @@ -176,6 +180,59 @@
>                         reg = <0x10000000 0x100>;
>                 };
>
> +               hsi2c_0: hsi2c@12DA0000 {

Lower case node names (@12da0000).
How about putting the nodes close to the other nodes with such
addresses? That would be at the end of the soc node.

> +                       compatible = "samsung,exynos5260-hsi2c";
> +                       reg = <0x12DA0000 0x1000>;
> +                       interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c0_hs_bus>;
> +                       clocks = <&clock_peri PERI_CLK_HSIC0>;
> +                       clock-names = "hsi2c";
> +                       status = "disabled";
> +               };
> +
> +               hsi2c_1: hsi2c@12DB0000 {
> +                       compatible = "samsung,exynos5260-hsi2c";
> +                       reg = <0x12DB0000 0x1000>;
> +                       interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c1_hs_bus>;
> +                       clocks = <&clock_peri PERI_CLK_HSIC1>;
> +                       clock-names = "hsi2c";
> +                       status = "disabled";
> +               };
> +
> +               hsi2c_2: hsi2c@12DC0000 {
> +                       compatible = "samsung,exynos5260-hsi2c";
> +                       reg = <0x12DC0000 0x1000>;
> +                       interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c2_hs_bus>;
> +                       clocks = <&clock_peri PERI_CLK_HSIC2>;
> +                       clock-names = "hsi2c";
> +                       status = "disabled";
> +               };
> +
> +               hsi2c_3: hsi2c@12DD0000 {
> +                       compatible = "samsung,exynos5260-hsi2c";
> +                       samsung,check-transdone-int;

This looks like undocumented property. Did you add a new driver with it?

Best regards,
Krzysztof

> +                       reg = <0x12DD0000 0x1000>;
> +                       interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&i2c3_hs_bus>;
> +                       clocks = <&clock_peri PERI_CLK_HSIC3>;
> +                       clock-names = "hsi2c";
> +                       status = "disabled";
> +               };
> +
>                 mct: mct@100b0000 {
>                         compatible = "samsung,exynos4210-mct";
>                         reg = <0x100B0000 0x1000>;
> --
> 2.13.6
>

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/exynos5260.dtsi b/arch/arm/boot/dts/exynos5260.dtsi
index 14b423de9137..5f75ff422043 100644
--- a/arch/arm/boot/dts/exynos5260.dtsi
+++ b/arch/arm/boot/dts/exynos5260.dtsi
@@ -17,6 +17,10 @@ 
 	#size-cells = <1>;
 
 	aliases {
+		i2c0 = &hsi2c_0;
+		i2c1 = &hsi2c_1;
+		i2c2 = &hsi2c_2;
+		i2c3 = &hsi2c_3;
 		pinctrl0 = &pinctrl_0;
 		pinctrl1 = &pinctrl_1;
 		pinctrl2 = &pinctrl_2;
@@ -176,6 +180,59 @@ 
 			reg = <0x10000000 0x100>;
 		};
 
+		hsi2c_0: hsi2c@12DA0000 {
+			compatible = "samsung,exynos5260-hsi2c";
+			reg = <0x12DA0000 0x1000>;
+			interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c0_hs_bus>;
+			clocks = <&clock_peri PERI_CLK_HSIC0>;
+			clock-names = "hsi2c";
+			status = "disabled";
+		};
+
+		hsi2c_1: hsi2c@12DB0000 {
+			compatible = "samsung,exynos5260-hsi2c";
+			reg = <0x12DB0000 0x1000>;
+			interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c1_hs_bus>;
+			clocks = <&clock_peri PERI_CLK_HSIC1>;
+			clock-names = "hsi2c";
+			status = "disabled";
+		};
+
+		hsi2c_2: hsi2c@12DC0000 {
+			compatible = "samsung,exynos5260-hsi2c";
+			reg = <0x12DC0000 0x1000>;
+			interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c2_hs_bus>;
+			clocks = <&clock_peri PERI_CLK_HSIC2>;
+			clock-names = "hsi2c";
+			status = "disabled";
+		};
+
+		hsi2c_3: hsi2c@12DD0000 {
+			compatible = "samsung,exynos5260-hsi2c";
+			samsung,check-transdone-int;
+			reg = <0x12DD0000 0x1000>;
+			interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			pinctrl-names = "default";
+			pinctrl-0 = <&i2c3_hs_bus>;
+			clocks = <&clock_peri PERI_CLK_HSIC3>;
+			clock-names = "hsi2c";
+			status = "disabled";
+		};
+
 		mct: mct@100b0000 {
 			compatible = "samsung,exynos4210-mct";
 			reg = <0x100B0000 0x1000>;