diff mbox series

[1/6] regulator: da9063: remove platform_data support

Message ID 20190318154759.21978-2-wsa+renesas@sang-engineering.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series mfd: da9063: remove platform_data | expand

Commit Message

Wolfram Sang March 18, 2019, 3:47 p.m. UTC
There are no in-kernel users anymore, so remove this outdated interface.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/regulator/da9063-regulator.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Simon Horman March 19, 2019, 12:49 p.m. UTC | #1
On Mon, Mar 18, 2019 at 04:47:53PM +0100, Wolfram Sang wrote:
> There are no in-kernel users anymore, so remove this outdated interface.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  drivers/regulator/da9063-regulator.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
> index 2b0c7a85306a..73c85039d0cf 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -730,7 +730,6 @@ static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
>  static int da9063_regulator_probe(struct platform_device *pdev)
>  {
>  	struct da9063 *da9063 = dev_get_drvdata(pdev->dev.parent);
> -	struct da9063_pdata *da9063_pdata = dev_get_platdata(da9063->dev);
>  	struct of_regulator_match *da9063_reg_matches = NULL;
>  	struct da9063_regulators_pdata *regl_pdata;
>  	const struct da9063_dev_model *model;
> @@ -740,11 +739,7 @@ static int da9063_regulator_probe(struct platform_device *pdev)
>  	bool bcores_merged, bmem_bio_merged;
>  	int id, irq, n, n_regulators, ret, val;
>  
> -	regl_pdata = da9063_pdata ? da9063_pdata->regulators_pdata : NULL;
> -
> -	if (!regl_pdata)
> -		regl_pdata = da9063_parse_regulators_dt(pdev,
> -							&da9063_reg_matches);
> +	regl_pdata = da9063_parse_regulators_dt(pdev, &da9063_reg_matches);
>  
>  	if (IS_ERR(regl_pdata) || regl_pdata->n_regulators == 0) {
>  		dev_err(&pdev->dev,
> -- 
> 2.11.0
>
Steve Twiss March 29, 2019, 10:57 a.m. UTC | #2
Hi,

On 18 March 2019 15:48, Wolfram Sang wrote:

> Subject: [PATCH 1/6] regulator: da9063: remove platform_data support
> 
> There are no in-kernel users anymore, so remove this outdated interface.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/regulator/da9063-regulator.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Thanks!
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>

Regards,
Steve
diff mbox series

Patch

diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index 2b0c7a85306a..73c85039d0cf 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -730,7 +730,6 @@  static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
 static int da9063_regulator_probe(struct platform_device *pdev)
 {
 	struct da9063 *da9063 = dev_get_drvdata(pdev->dev.parent);
-	struct da9063_pdata *da9063_pdata = dev_get_platdata(da9063->dev);
 	struct of_regulator_match *da9063_reg_matches = NULL;
 	struct da9063_regulators_pdata *regl_pdata;
 	const struct da9063_dev_model *model;
@@ -740,11 +739,7 @@  static int da9063_regulator_probe(struct platform_device *pdev)
 	bool bcores_merged, bmem_bio_merged;
 	int id, irq, n, n_regulators, ret, val;
 
-	regl_pdata = da9063_pdata ? da9063_pdata->regulators_pdata : NULL;
-
-	if (!regl_pdata)
-		regl_pdata = da9063_parse_regulators_dt(pdev,
-							&da9063_reg_matches);
+	regl_pdata = da9063_parse_regulators_dt(pdev, &da9063_reg_matches);
 
 	if (IS_ERR(regl_pdata) || regl_pdata->n_regulators == 0) {
 		dev_err(&pdev->dev,