| Message ID | 20190404184914.12819-1-Larry.Finger@lwfinger.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b25105e126e79d8fb5a8c33b009a653f4a4aea71 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | b43: Remove empty function lpphy_papd_cal() | expand |
Larry Finger <Larry.Finger@lwfinger.net> wrote: > In commit d825db346270e ("b43: shut up clang -Wuninitialized variable > warning"), the message noted that function lpphy_papd_cal() was empty > and had an old TODO regarding its implementation. As the reverse > engineering project that created the LP-PHY version of this driver > has not been active for some time, it is safe to remove this empty > function. > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Arnd Bergmann <arnd@arndb.de> Patch applied to wireless-drivers-next.git, thanks. b25105e126e7 b43: Remove empty function lpphy_papd_cal()
diff --git a/drivers/net/wireless/broadcom/b43/phy_lp.c b/drivers/net/wireless/broadcom/b43/phy_lp.c index aedee026c5e2..6b7f0238723f 100644 --- a/drivers/net/wireless/broadcom/b43/phy_lp.c +++ b/drivers/net/wireless/broadcom/b43/phy_lp.c @@ -1826,12 +1826,6 @@ static void lpphy_stop_tx_tone(struct b43_wldev *dev) } -static void lpphy_papd_cal(struct b43_wldev *dev, struct lpphy_tx_gains gains, - int mode, bool useindex, u8 index) -{ - //TODO -} - static void lpphy_papd_cal_txpwr(struct b43_wldev *dev) { struct b43_phy_lp *lpphy = dev->phy.lp; @@ -1848,11 +1842,6 @@ static void lpphy_papd_cal_txpwr(struct b43_wldev *dev) lpphy_set_tx_power_control(dev, B43_LPPHY_TXPCTL_OFF); - if (dev->dev->chip_id == 0x4325 && dev->dev->chip_rev == 0) - lpphy_papd_cal(dev, oldgains, 0, 1, 30); - else - lpphy_papd_cal(dev, oldgains, 0, 1, 65); - if (old_afe_ovr) lpphy_set_tx_gains(dev, oldgains); lpphy_set_bb_mult(dev, old_bbmult);
In commit d825db346270e ("b43: shut up clang -Wuninitialized variable warning"), the message noted that function lpphy_papd_cal() was empty and had an old TODO regarding its implementation. As the reverse engineering project that created the LP-PHY version of this driver has not been active for some time, it is safe to remove this empty function. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Cc: Arnd Bergmann <arnd@arndb.de> --- drivers/net/wireless/broadcom/b43/phy_lp.c | 11 ----------- 1 file changed, 11 deletions(-)