Message ID | 1557196098-1479-1-git-send-email-yhchuang@realtek.com (mailing list archive) |
---|---|
State | Accepted |
Commit | a24bad74737f4c8814e0669d38dba5f2ddb86514 |
Delegated to: | Kalle Valo |
Headers | show |
Series | [5.2,v3] rtw88: fix unassigned rssi_level in rtw_sta_info | expand |
<yhchuang@realtek.com> wrote: > From: Yan-Hsuan Chuang <yhchuang@realtek.com> > > The new rssi_level should be stored in si, otherwise the rssi_level will > never be updated and get a wrong RA mask, which is calculated by the > rssi level > > If a wrong RA mask is chosen, the firmware will pick some *bad rates*. > The most hurtful scene will be in *noisy environment*, such as office or > public area with many APs and users. > The latency would be high and the overall throughput would be only half > or less. > > Tested in 2.4G in office area, with this patch the throughput increased > from such as "1x Mbps -> 4x Mbps". > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com> Patch applied to wireless-drivers.git, thanks. a24bad74737f rtw88: fix unassigned rssi_level in rtw_sta_info
diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c index 4381b36..7f437e2 100644 --- a/drivers/net/wireless/realtek/rtw88/phy.c +++ b/drivers/net/wireless/realtek/rtw88/phy.c @@ -144,10 +144,10 @@ static void rtw_phy_stat_rssi_iter(void *data, struct ieee80211_sta *sta) struct rtw_phy_stat_iter_data *iter_data = data; struct rtw_dev *rtwdev = iter_data->rtwdev; struct rtw_sta_info *si = (struct rtw_sta_info *)sta->drv_priv; - u8 rssi, rssi_level; + u8 rssi; rssi = ewma_rssi_read(&si->avg_rssi); - rssi_level = rtw_phy_get_rssi_level(si->rssi_level, rssi); + si->rssi_level = rtw_phy_get_rssi_level(si->rssi_level, rssi); rtw_fw_send_rssi_info(rtwdev, si);