| Message ID | mvm36kgpg9z.fsf@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: export pm_power_off again | expand |
On Tue, Jun 11, 2019 at 12:28:40PM +0200, Andreas Schwab wrote: > Commit bf0102a0fdd9 ("riscv: call pm_power_off from machine_halt / > machine_power_off") removed the export of pm_power_off, but it is used by > several modules: > > ERROR: "pm_power_off" [drivers/mfd/rk808.ko] undefined! > ERROR: "pm_power_off" [drivers/mfd/max8907.ko] undefined! > ERROR: "pm_power_off" [drivers/mfd/axp20x.ko] undefined! > ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined! > > Signed-off-by: Andreas Schwab <schwab@suse.de> None of these drivers should be buildable on RISC-V. Please work with the maintainers to fix this up.
On Tue, 11 Jun 2019, Andreas Schwab wrote: > Commit bf0102a0fdd9 ("riscv: call pm_power_off from machine_halt / > machine_power_off") removed the export of pm_power_off, but it is used by > several modules: > > ERROR: "pm_power_off" [drivers/mfd/rk808.ko] undefined! > ERROR: "pm_power_off" [drivers/mfd/max8907.ko] undefined! > ERROR: "pm_power_off" [drivers/mfd/axp20x.ko] undefined! > ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined! > > Signed-off-by: Andreas Schwab <schwab@suse.de> Thanks, queued for v5.2-rc, along with a "Fixes:" line. - Paul
diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c index cfb6eb1d762d..d0fe623bfb8f 100644 --- a/arch/riscv/kernel/reset.c +++ b/arch/riscv/kernel/reset.c @@ -13,6 +13,7 @@ static void default_power_off(void) } void (*pm_power_off)(void) = default_power_off; +EXPORT_SYMBOL(pm_power_off); void machine_restart(char *cmd) {
Commit bf0102a0fdd9 ("riscv: call pm_power_off from machine_halt / machine_power_off") removed the export of pm_power_off, but it is used by several modules: ERROR: "pm_power_off" [drivers/mfd/rk808.ko] undefined! ERROR: "pm_power_off" [drivers/mfd/max8907.ko] undefined! ERROR: "pm_power_off" [drivers/mfd/axp20x.ko] undefined! ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined! Signed-off-by: Andreas Schwab <schwab@suse.de> --- arch/riscv/kernel/reset.c | 1 + 1 file changed, 1 insertion(+)