| Message ID | 1568109312-13175-1-git-send-email-dingxiang@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath9k: remove unneeded variable | expand |
Ding Xiang <dingxiang@cmss.chinamobile.com> wrote: > "len" is unneeded,just return 0 > > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> ALWAYS build check your patches! I admit that ATH_DUMP_BTCOEX() is an evil macro as it uses len variable in secret, but if you had compiled your patch you would have noticed this immeadiately. In file included from drivers/net/wireless/ath/ath9k/gpio.c:17: drivers/net/wireless/ath/ath9k/gpio.c: In function 'ath9k_dump_legacy_btcoex': drivers/net/wireless/ath/ath9k/ath9k.h:763:3: error: 'len' undeclared (first use in this function); did you mean '_end'? len += scnprintf(buf + len, size - len, \ ^~~ drivers/net/wireless/ath/ath9k/gpio.c:502:2: note: in expansion of macro 'ATH_DUMP_BTCOEX' ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type); ^~~~~~~~~~~~~~~ drivers/net/wireless/ath/ath9k/ath9k.h:763:3: note: each undeclared identifier is reported only once for each function it appears in len += scnprintf(buf + len, size - len, \ ^~~ drivers/net/wireless/ath/ath9k/gpio.c:502:2: note: in expansion of macro 'ATH_DUMP_BTCOEX' ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type); ^~~~~~~~~~~~~~~ make[5]: *** [drivers/net/wireless/ath/ath9k/gpio.o] Error 1 make[4]: *** [drivers/net/wireless/ath/ath9k] Error 2 make[3]: *** [drivers/net/wireless/ath] Error 2 make[2]: *** [drivers/net/wireless] Error 2 make[1]: *** [drivers/net] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2
diff --git a/drivers/net/wireless/ath/ath9k/gpio.c b/drivers/net/wireless/ath/ath9k/gpio.c index b457e52..f3d1bc0 100644 --- a/drivers/net/wireless/ath/ath9k/gpio.c +++ b/drivers/net/wireless/ath/ath9k/gpio.c @@ -498,14 +498,13 @@ static int ath9k_dump_legacy_btcoex(struct ath_softc *sc, u8 *buf, u32 size) { struct ath_btcoex *btcoex = &sc->btcoex; - u32 len = 0; ATH_DUMP_BTCOEX("Stomp Type", btcoex->bt_stomp_type); ATH_DUMP_BTCOEX("BTCoex Period (msec)", btcoex->btcoex_period); ATH_DUMP_BTCOEX("Duty Cycle", btcoex->duty_cycle); ATH_DUMP_BTCOEX("BT Wait time", btcoex->bt_wait_time); - return len; + return 0; } int ath9k_dump_btcoex(struct ath_softc *sc, u8 *buf, u32 size)
"len" is unneeded,just return 0 Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> --- drivers/net/wireless/ath/ath9k/gpio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)