| Message ID | 20190917065044.GA173797@LGEARND20B15 (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6e7d59776311e181160d44ed3c73cc7e65def7f2 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable | expand |
Hello, Maintainers... Would you please review above patch if you are available? Thanks, Austin Kim 2019년 9월 17일 (화) 오후 3:50, Austin Kim <austindh.kim@gmail.com>님이 작성: > > 'rtstatus' local variable is not used, > so remove it for clean-up. > > Signed-off-by: Austin Kim <austindh.kim@gmail.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c > index 54a3aec..22441dd 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c > @@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw, > enum radio_path rfpath) > { > int i; > - bool rtstatus = true; > u32 *radioa_array_table; > u16 radioa_arraylen; > > radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH; > radioa_array_table = RTL8723E_RADIOA_1TARRAY; > > - rtstatus = true; > - > switch (rfpath) { > case RF90_PATH_A: > for (i = 0; i < radioa_arraylen; i = i + 2) { > -- > 2.6.2 >
> -----Original Message----- > From: Austin Kim [mailto:austindh.kim@gmail.com] > Sent: Monday, September 23, 2019 9:35 PM > To: Pkshih; kvalo@codeaurora.org; davem@davemloft.net > Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable > > Hello, Maintainers... > Would you please review above patch if you are available? > You can check status of your patch here https://patchwork.kernel.org/project/linux-wireless/list/?series=174859 If your patch is existing in patchwork, maintainer doesn't forget it. Another thing is to avoid top posting that makes maintainer hard to read mail. --- PK
Austin Kim <austindh.kim@gmail.com> wrote: > 'rtstatus' local variable is not used, > so remove it for clean-up. > > Signed-off-by: Austin Kim <austindh.kim@gmail.com> Patch applied to wireless-drivers-next.git, thanks. 6e7d59776311 rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable
2019년 10월 1일 (화) 오후 6:20, Kalle Valo <kvalo@codeaurora.org>님이 작성: > > Austin Kim <austindh.kim@gmail.com> wrote: > > > 'rtstatus' local variable is not used, > > so remove it for clean-up. > > > > Signed-off-by: Austin Kim <austindh.kim@gmail.com> > > Patch applied to wireless-drivers-next.git, thanks. Thanks for information.
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c index 54a3aec..22441dd 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c @@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw, enum radio_path rfpath) { int i; - bool rtstatus = true; u32 *radioa_array_table; u16 radioa_arraylen; radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH; radioa_array_table = RTL8723E_RADIOA_1TARRAY; - rtstatus = true; - switch (rfpath) { case RF90_PATH_A: for (i = 0; i < radioa_arraylen; i = i + 2) {
'rtstatus' local variable is not used, so remove it for clean-up. Signed-off-by: Austin Kim <austindh.kim@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 --- 1 file changed, 3 deletions(-)